Replce mongo obsolate api and add enum to string convetion #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
glucaci
commented
Dec 3, 2019
glucaci
commented
- Replace create index obsoleted api
- Add convention pack to serialize Enum's as string value (more readable)
| new ConventionPack | ||
| { | ||
| new EnumRepresentationConvention(BsonType.String) | ||
| }, t => t.FullName?.StartsWith("WorkflowCore") ?? false); |
There was a problem hiding this comment.
is this compatible with existing databases out there that have done it the old way?
There was a problem hiding this comment.
Yes, it can serialize/deserialize in both ways. The new or replaced documents will have the new representation and the old ones will remain as they are.
danielgerlag
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.