Skip to content

Replce mongo obsolate api and add enum to string convetion #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Replce mongo obsolate api and add enum to string convetion #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18e9522
Replace obsolate index creation method
glucaci Dec 3, 2019
1ef942a
Add enum to string convention
glucaci Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/providers/WorkflowCore.Persistence.MongoDB/Services/MongoPersistenceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using MongoDB.Bson;
using MongoDB.Bson.Serialization.Conventions;
using MongoDB.Driver.Linq;
using WorkflowCore.Interface;
using WorkflowCore.Models;
Expand All @@ -24,6 +26,13 @@ public MongoPersistenceProvider(IMongoDatabase database)

static MongoPersistenceProvider()
{
ConventionRegistry.Register(
"workflow.conventions",
new ConventionPack
{
new EnumRepresentationConvention(BsonType.String)
}, t => t.FullName?.StartsWith("WorkflowCore") ?? false);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this compatible with existing databases out there that have done it the old way?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it can serialize/deserialize in both ways. The new or replaced documents will have the new representation and the old ones will remain as they are.


BsonClassMap.RegisterClassMap<WorkflowInstance>(x =>
{
x.MapIdProperty(y => y.Id)
Expand Down Expand Up @@ -72,8 +81,14 @@ static void CreateIndexes(MongoPersistenceProvider instance)
{
if (!indexesCreated)
{
instance.WorkflowInstances.Indexes.CreateOne(Builders<WorkflowInstance>.IndexKeys.Ascending(x => x.NextExecution), new CreateIndexOptions() { Background = true, Name = "idx_nextExec" });
instance.Events.Indexes.CreateOne(Builders<Event>.IndexKeys.Ascending(x => x.IsProcessed), new CreateIndexOptions() { Background = true, Name = "idx_processed" });
instance.WorkflowInstances.Indexes.CreateOne(new CreateIndexModel<WorkflowInstance>(
Builders<WorkflowInstance>.IndexKeys.Ascending(x => x.NextExecution),
new CreateIndexOptions {Background = true, Name = "idx_nextExec"}));

instance.Events.Indexes.CreateOne(new CreateIndexModel<Event>(
Builders<Event>.IndexKeys.Ascending(x => x.IsProcessed),
new CreateIndexOptions {Background = true, Name = "idx_processed"}));

indexesCreated = true;
}
}
Expand Down