Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapp verify-contract fails with "jays: error in -e" #753

Closed
transmissions11 opened this issue Aug 26, 2021 · 12 comments
Closed

dapp verify-contract fails with "jays: error in -e" #753

transmissions11 opened this issue Aug 26, 2021 · 12 comments

Comments

@transmissions11
Copy link
Contributor

❯ ETHERSCAN_API_KEY=REDACTED dapp verify-contract RolesAuthority 0x9ed0e3fe49af99a8907361d9b7caea8f214fe288
jays: error in -e
@transmissions11
Copy link
Contributor Author

Ran this command in the solmate repo

@transmissions11
Copy link
Contributor Author

Oop should have specified a path like so:

dapp verify-contract src/auth/authorities/RolesAuthority.sol:RolesAuthority 0x9ed0e3fe49af99a8907361d9b7caea8f214fe288

@d-xo
Copy link
Contributor

d-xo commented Aug 26, 2021

Wonder if we can improve the error message here 🤔

@odyslam
Copy link
Contributor

odyslam commented Sep 15, 2021

It took me solid 30m to find this issue and understand the right syntax. Adding your example in the docs @transmissions11

@transmissions11
Copy link
Contributor Author

It took me solid 30m to find this issue and understand the right syntax. Adding your example in the docs @transmissions11

ayy thx good idea!

@transmissions11
Copy link
Contributor Author

i wonder if we could update --verify to accept just a contract name like dapp deploy... @d-xo ?

@d-xo
Copy link
Contributor

d-xo commented Sep 15, 2021

I think it should be possible, and I think it sounds like a good idea 🙂

@transmissions11
Copy link
Contributor Author

I think it should be possible, and I think it sounds like a good idea 🙂

kk will give it a shot!

odyslam added a commit to odyslam/dapptools that referenced this issue Sep 16, 2021
odyslam added a commit to odyslam/dapptools that referenced this issue Sep 16, 2021
@odyslam
Copy link
Contributor

odyslam commented Sep 16, 2021

@transmissions11 I was thinking in taking a stab at it.

Can we assume that the command is meant to be run inside the directory where the dapptools project lives? Thus, expect source files to live in /src, etc.

@transmissions11
Copy link
Contributor Author

@transmissions11 I was thinking in taking a stab at it.

i've already got a WIP branch for this but if you're gonna frontrun me can you extract the logic into a generic command like dapp---get-contract so the same logic can be used across dapp create/dapp verify-contract and future commands that use dapp.out.json data 🙏

@odyslam
Copy link
Contributor

odyslam commented Sep 16, 2021

Nah, there is no reason to do double work. There is more than enough features for everyone to go around.

Thanks for picking this up!

@TimDaub
Copy link
Contributor

TimDaub commented Feb 10, 2022

I still get this cryptic error despite specifying path.sol:contractName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants