-
Notifications
You must be signed in to change notification settings - Fork 94
Use environment variables to initialize client and server #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use environment variables to initialize client and server #192
Conversation
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
/cc @XavierGeerinck for review |
One extra question: I see you are using I personally prefer |
@XavierGeerinck, I had seen From https://stackoverflow.com/questions/61480993/when-should-i-use-nullish-coalescing-vs-logical-or,
What do you think? |
Awesome, LGTM |
Description
This PR makes
DaprClient
andDaprServer
configurable using environment variables. If missing, they fallback to a sane default value.Issue reference
Please reference the issue this PR will close: #178
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: