Update Eslint configuration to enforce error for unused vars rule #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
|
Merged |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Sharma shubhash@microsoft.com
Description
Per #195, we were looking to enforce eslint, but it already configures each rule as "error" by default. The only rule we were throwing warning for was "@typescript-eslint/no-unused-vars" and this PR changes that. Now, it errors out like this:
Issue reference
Please reference the issue this PR will close: #195
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: