Add documentation clarification #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
shubham1172
reviewed
Mar 1, 2022
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
shubham1172
reviewed
Mar 1, 2022
|
|
||
| The above communication can be configured to use either of the gRPC or HTTP protocols. | ||
|
|
||
|  |
There was a problem hiding this comment.
The images look slightly oversized in the preview, do you want to constraint it to a specific size? https://github.com/dapr/js-sdk/blob/aa14ebf406fb0ac376d6306971503a244011d771/daprdocs/content/en/js-sdk-docs/_index.md
|
Looks good to me as well! @XavierGeerinck |
amulyavarote
approved these changes
Mar 1, 2022
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xavier Geerinck xavier.geerinck@gmail.com
Description
Clarify documentation for:
Issue reference
This works on issues #152 and #159
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: