Skip to content

Conversation

shubham1172
Copy link
Member

Description

Update example to point to build, instead of an old dapr-client version.

Issue reference

Please reference the issue this PR will close: #215

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • (NA) Created/updated tests
  • (NA) Extended the documentation

@shubham1172 shubham1172 requested review from a team as code owners March 16, 2022 12:29
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #216 (161d32b) into master (7520670) will decrease coverage by 5.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   30.70%   25.28%   -5.42%     
==========================================
  Files          70       64       -6     
  Lines        5472     5402      -70     
  Branches      172      172              
==========================================
- Hits         1680     1366     -314     
- Misses       3758     4032     +274     
+ Partials       34        4      -30     
Impacted Files Coverage Δ
src/actors/client/ActorProxyBuilder.ts 11.76% <0.00%> (-88.24%) ⬇️
src/implementation/Server/HTTPServer/actor.ts 7.50% <0.00%> (-85.00%) ⬇️
src/implementation/Server/HTTPServer/HTTPServer.ts 12.24% <0.00%> (-71.43%) ⬇️
src/actors/ActorId.ts 33.33% <0.00%> (-66.67%) ⬇️
src/implementation/Client/HTTPClient/health.ts 16.66% <0.00%> (-66.67%) ⬇️
src/actors/runtime/AbstractActor.ts 11.42% <0.00%> (-62.86%) ⬇️
src/actors/runtime/ActorRuntimeConfig.ts 13.33% <0.00%> (-60.00%) ⬇️
src/actors/runtime/ActorRuntime.ts 13.51% <0.00%> (-59.46%) ⬇️
src/actors/runtime/ActorManager.ts 12.19% <0.00%> (-58.54%) ⬇️
src/implementation/Client/HTTPClient/actor.ts 42.85% <0.00%> (-57.15%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7520670...161d32b. Read the comment docs.

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 force-pushed the shubham1172/fix-example branch from 9a6fed8 to 161d32b Compare March 16, 2022 12:31
@XavierGeerinck XavierGeerinck merged commit b6c87b5 into dapr:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix actor example

2 participants