Skip to content

Conversation

XavierGeerinck
Copy link
Contributor

Description

Implement the configuration API

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #140

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
@XavierGeerinck XavierGeerinck requested review from a team as code owners April 4, 2022 12:51
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #242 (ac259ab) into master (6a9d715) will decrease coverage by 0.00%.
The diff coverage is 11.59%.

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   30.56%   30.55%   -0.01%     
==========================================
  Files          70       74       +4     
  Lines        5644     5740      +96     
  Branches      172      183      +11     
==========================================
+ Hits         1725     1754      +29     
- Misses       3885     3949      +64     
- Partials       34       37       +3     
Impacted Files Coverage Δ
src/implementation/Server/GRPCServer/actor.ts 16.66% <0.00%> (ø)
.../implementation/Client/GRPCClient/configuration.ts 5.45% <5.45%> (ø)
.../implementation/Client/HTTPClient/configuration.ts 33.33% <33.33%> (ø)
src/implementation/Client/DaprClient.ts 68.65% <75.00%> (+0.40%) ⬆️
src/actors/client/ActorClient/ActorClientHTTP.ts 40.00% <0.00%> (-4.45%) ⬇️
src/actors/runtime/ActorReminderData.ts 50.00% <0.00%> (-2.95%) ⬇️
src/actors/client/ActorClient/ActorClientGRPC.ts 3.41% <0.00%> (-0.13%) ⬇️
src/index.ts 100.00% <0.00%> (ø)
test/actor/DemoActorTimerImpl.ts 88.88% <0.00%> (ø)
src/actors/runtime/AbstractActor.ts 74.28% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9d715...ac259ab. Read the comment docs.

Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
Copy link
Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @XavierGeerinck, LGTM!

@XavierGeerinck XavierGeerinck merged commit b827da6 into dapr:master May 5, 2022
@XavierGeerinck XavierGeerinck deleted the issue_140 branch May 5, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Configuration API
3 participants