Skip to content

Conversation

shubham1172
Copy link
Member

@shubham1172 shubham1172 commented Apr 26, 2022

Signed-off-by: Shubham Sharma shubhash@microsoft.com

Description

The actor documentation and examples were broken. This PR

  1. Updates the documentation
    1. Update actor invoke using proxy
    2. Clean up and nits
  2. Complete the actor parking space example
    1. Updated the actors implementation
    2. Added grafana, telegraf and influxDB setup behind docker-compose
  3. Refactor and fix the actor default example

Issue reference

Please reference the issue this PR will close: #98

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@shubham1172 shubham1172 requested review from a team as code owners April 26, 2022 17:29
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #252 (f544d8e) into master (eb6ee2e) will increase coverage by 5.49%.
The diff coverage is 100.00%.

❗ Current head f544d8e differs from pull request most recent head 1ca2ca9. Consider uploading reports for the commit 1ca2ca9 to get more accurate results

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   25.27%   30.76%   +5.49%     
==========================================
  Files          64       72       +8     
  Lines        5583     5675      +92     
  Branches      177      177              
==========================================
+ Hits         1411     1746     +335     
+ Misses       4168     3892     -276     
- Partials        4       37      +33     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
test/actor/DemoActorCounterImpl.ts 71.42% <0.00%> (ø)
test/actor/DemoActorActivateImpl.ts 6.25% <0.00%> (ø)
test/actor/DemoActorTimerImpl.ts 88.88% <0.00%> (ø)
test/actor/DemoActorReminderImpl.ts 88.88% <0.00%> (ø)
test/actor/DemoActorTimerTtlImpl.ts 88.88% <0.00%> (ø)
test/actor/DemoActorReminder2Impl.ts 87.50% <0.00%> (ø)
test/actor/DemoActorSayImpl.ts 100.00% <0.00%> (ø)
test/actor/DemoActorReminderTtlImpl.ts 88.88% <0.00%> (ø)
src/actors/runtime/StateProvider.ts 14.28% <0.00%> (+4.76%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6ee2e...1ca2ca9. Read the comment docs.

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 force-pushed the shubham1172/actors-docs branch from a049c99 to 83ede32 Compare April 28, 2022 18:37
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 changed the title [WIP] Fix actors documentation and examples Fix actors documentation and examples Apr 29, 2022
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@XavierGeerinck
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

actors documentation
2 participants