Skip to content

Conversation

zcong1993
Copy link
Contributor

@zcong1993 zcong1993 commented Sep 8, 2021

Description

  1. make genreated *_pb.d.ts files base on @grpc/grpc-js not grpc, and regenerate grpc files (not update proto files from dapr master)
  2. migrate src/implementation/Server/GRPCServer/GRPCServerImpl.ts to @grpc/grpc-js (only the typings is modified without changing any logic code)
  3. remove dependency package grpc

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@ghost
Copy link

ghost commented Sep 8, 2021

CLA assistant check
All CLA requirements met.

@XavierGeerinck XavierGeerinck merged commit 3fe6b21 into dapr:master Sep 15, 2021
@XavierGeerinck
Copy link
Contributor

Thanks a lot for your contribution! Looking good, merged it so it can go into the release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants