Crop to exact size

[mdebooy]

Is your feature request related to a problem? Please describe.
When I want to crop my picture to an exact size then this is not easy. It is not always possible to 'drag' the right size. Also on some pictures the size is not easy to read. Sometimes the selected size is not used when you do an export. The picture is sometimes 1 pixel too small.

Describe the solution you'd like
It would be nice if the user can enter the size by entering the x and/or y size manually. The option to enter values is available in many modules. In the 'Crop and Resize' module it is already possible to enter the degrees to rotate but not the x and/or y crop size.

Describe alternatives you've considered
I asked the question on darktable-user@lists.darktable.org. I now crop to a size a bit bigger than needed and do another crop in GIMP.

Additional context
Add any other context or screenshots about the feature request here.

[TurboGit]

Crop is about ratio not size. You crop the are you're seeing then you export it at the size you want. So I'm not sure what you want this for.

[MStraeten]

the actual implementation ist about ratio and size. It allows cropping by seeing and dragging, but not by defining. For example, you cannot define that you want to cut a 1:1 FullHD extract from the image.
So in my opinion the labeling as ‚invalid‘ needs discussion.

[parafin]

Cutting FullHD frame from picture is not a valid use-case for darktable IMHO, it's more of GIMP or even ImageMagick area. But getting 1:1 output might be desired in case user don't want to involve any scaling. And sometimes he may want to fit the resulting image in some resolution. So I would say use-cases for this feature are not very well defined, but still it's a valid feature request.

[lesnake]

I started working on that ~15 days ago. if you want to try it :
https://github.com/lesnake/darktable/tree/numeric-crop-ctrl
I need to translate strings to french at least, and I request for review.

[lesnake]

[mdebooy]

Thank you for your work. It looks good on your screenshot. I have 3 issues with your solution. First of all, will it be merged into darktable? One of the maintainers blocked my request and I do not want to switch to a forked version. Secondly, I am not familiar with compiling C applications (I am more a Java guy). Do I need to install specific libraries before I can compile? As a last issue, do I need to replace the whole application or can I just copy the module 'crop and rotate'? If yes, what do I need to copy? Op 23-08-19 om 22:34 schreef lesnake:

I started working on that ~15 days ago. if you want to try it : https://github.com/lesnake/darktable/tree/numeric-crop-ctrl — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2849?email_source=notifications&email_token=AD43NRWHHDNVUWXUXXK2ANDQGBCVXA5CNFSM4IK4RQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BIK5A#issuecomment-524453236>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD43NRULNQGFWR2MRISFATDQGBCVXANCNFSM4IK4RQ5Q>.

Capture d’écran du 2019-08-23 22-35-37 <https://user-images.githubusercontent.com/3767451/63622421-ff751280-c5f6-11e9-95dc-9940d329a48f.png>

[lesnake]

1 - This is not in my hands. I don't have started the review process (which I have never done so far).
I'm on the localization stuff.
I think that I can defend the function so that is it is accepted.

2 - You can find directions do build at the project root on github :
https://github.com/darktable-org/darktable
Just pull my repository https://github.com/lesnake/darktable instead
and checkout branch numeric-crop-ctrl

3 - I don't know
You can install it in another folder using a different prefix.
I suggest that you use another picture database and config folders, just in case, by using --datadir --configdir --library
There is no directions on good/best development practices (container ?).
This is what I did.

[mdebooy]

Thank you. I will give it a try. Op 25-08-19 om 16:22 schreef lesnake:

…

1 - This is not in my hands. I don't have started the review process (which I have never done so far). I'm on the localization stuff. I think that I can defend the function so that is it is accepted. 2 - You can find directions do build at the project root on github : https://github.com/darktable-org/darktable Just pull my repository https://github.com/lesnake/darktable instead and checkout branch numeric-crop-ctrl 3 - I don't know You can install it in another folder using a different prefix. I suggest that you use another picture database and config folders, just in case, by using --datadir --configdir --library There is no directions on good/best development practices (container ?). This is what I did. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2849?email_source=notifications&email_token=AD43NRWXD24TULGXU5XBKL3QGKIT5A5CNFSM4IK4RQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CURNA#issuecomment-524634292>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD43NRQR3O4U6ZCTVIAYXTLQGKIT5ANCNFSM4IK4RQ5Q>.

[mdebooy]

I will be happy to do some tests for you. I installed the packages that are mentioned in the wiki for the 2.6.0 version and did the commands on your page (git clone in the myDarktable directory and git checkout numeric-crop-ctrl and both git submodule in the darktable directory). Unfortunately the build failed with the following errors: [ 63%] Building C object src/iop/CMakeFiles/dither.dir/introspection_dither.c.o In file included from /srv/local/Marco/myDarktable/darktable/build/src/iop/introspection_clipping.c:75:0: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c: In function ‘legacy_params’: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:115:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]      uint32_t intk = *(uint32_t *)&o->k_h;      ^~~~~~~~ /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:122:5: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]      float floatk = *(float *)&intk;      ^~~~~ /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c: In function ‘groups’: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:310:27: error: passing argument 1 of ‘dt_iop_get_group’ from incompatible pointer type [-Werror=incompatible-pointer-types]    return dt_iop_get_group("crop and rotate", IOP_GROUP_BASIC);                            ^~~~~~~~~~~~~~~~~ In file included from /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:37:0,                  from /srv/local/Marco/myDarktable/darktable/build/src/iop/introspection_clipping.c:75: /srv/local/Marco/myDarktable/darktable/src/common/iop_group.h:24:5: note: expected ‘const dt_iop_module_t * {aka const struct dt_iop_module_t *}’ but argument is of type ‘char *’  int dt_iop_get_group(const dt_iop_module_t *module);      ^~~~~~~~~~~~~~~~ In file included from /srv/local/Marco/myDarktable/darktable/build/src/iop/introspection_clipping.c:75:0: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:310:10: error: too many arguments to function ‘dt_iop_get_group’    return dt_iop_get_group("crop and rotate", IOP_GROUP_BASIC);           ^~~~~~~~~~~~~~~~ In file included from /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:37:0,                  from /srv/local/Marco/myDarktable/darktable/build/src/iop/introspection_clipping.c:75: /srv/local/Marco/myDarktable/darktable/src/common/iop_group.h:24:5: note: declared here  int dt_iop_get_group(const dt_iop_module_t *module);      ^~~~~~~~~~~~~~~~ In file included from /srv/local/Marco/myDarktable/darktable/build/src/iop/introspection_clipping.c:75:0: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c: In function ‘_iop_clipping_set_max_clip’: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:548:77: error: ‘struct dt_iop_module_t’ has no member named ‘priority’    if(!dt_dev_distort_transform_plus(self->dev, self->dev->preview_pipe, self->priority + 1, 999999, points, 4)) ^~ /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c: In function ‘process_cl’: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:932:78: error: ‘struct dt_iop_module_t’ has no member named ‘data’; did you mean ‘dt’?    dt_iop_clipping_global_data_t *gd = (dt_iop_clipping_global_data_t *)self->data; ^~~~ dt /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c: In function ‘init’: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:1728:9: error: ‘dt_iop_module_t {aka struct dt_iop_module_t}’ has no member named ‘priority’    module->priority = 285; // module order created by iop_dependencies.py, do not edit!          ^~ In file included from /srv/local/Marco/myDarktable/darktable/build/src/iop/introspection_clipping.c:75:0: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c: In function ‘gui_post_expose’: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:2579:78: error: ‘struct dt_iop_module_t’ has no member named ‘priority’      if(dt_dev_distort_transform_plus(self->dev, self->dev->preview_pipe, self->priority + 1, 999999, pts, 4)) ^~ /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c: In function ‘mouse_moved’: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:2868:81: error: ‘struct dt_iop_module_t’ has no member named ‘priority’        dt_dev_distort_backtransform_plus(self->dev, self->dev->preview_pipe, self->priority + 1, 9999999, pts, ^~ /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:3050:84: error: ‘struct dt_iop_module_t’ has no member named ‘priority’        if(dt_dev_distort_backtransform_plus(self->dev, self->dev->preview_pipe, self->priority + 1, 9999999, ^~ /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:3103:81: error: ‘struct dt_iop_module_t’ has no member named ‘priority’        dt_dev_distort_backtransform_plus(self->dev, self->dev->preview_pipe, self->priority + 1, 9999999, pts, ^~ /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c: In function ‘commit_box’: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:3162:80: error: ‘dt_iop_module_t {aka struct dt_iop_module_t}’ has no member named ‘priority’    if(dt_dev_distort_backtransform_plus(self->dev, self->dev->preview_pipe, self->priority + 1, 9999999, ^~ /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c: In function ‘button_pressed’: /srv/local/Marco/myDarktable/darktable/src/iop/clipping.c:3264:79: error: ‘struct dt_iop_module_t’ has no member named ‘priority’          dt_dev_distort_transform_plus(self->dev, self->dev->preview_pipe, self->priority + 1, 999999, pts, 4); ^~ cc1: all warnings being treated as errors [ 63%] Built target temperature src/iop/CMakeFiles/clipping.dir/build.make:67: recipe for target 'src/iop/CMakeFiles/clipping.dir/introspection_clipping.c.o' failed make[2]: *** [src/iop/CMakeFiles/clipping.dir/introspection_clipping.c.o] Error 1 CMakeFiles/Makefile2:4678: recipe for target 'src/iop/CMakeFiles/clipping.dir/all' failed make[1]: *** [src/iop/CMakeFiles/clipping.dir/all] Error 2 make[1]: *** Wachten op onvoltooide taken... [ 64%] Generating introspection_bloom.c Scanning dependencies of target bloom [ 64%] Building C object src/iop/CMakeFiles/bloom.dir/introspection_bloom.c.o [ 64%] Linking C shared module libdither.so [ 64%] Linking C shared module libbloom.so [ 64%] Built target dither [ 64%] Linking C shared module libdenoiseprofile.so [ 64%] Built target bloom [ 64%] Built target denoiseprofile Makefile:151: recipe for target 'all' failed make: *** [all] Error 2 booymar@farao:/srv/local/Marco/myDarktable/darktable$ I do not know if I did something wrong. Perhaps you have an idea. Op 25-08-19 om 16:22 schreef lesnake:

…

1 - This is not in my hands. I don't have started the review process (which I have never done so far). I'm on the localization stuff. I think that I can defend the function so that is it is accepted. 2 - You can find directions do build at the project root on github : https://github.com/darktable-org/darktable Just pull my repository https://github.com/lesnake/darktable instead and checkout branch numeric-crop-ctrl 3 - I don't know You can install it in another folder using a different prefix. I suggest that you use another picture database and config folders, just in case, by using --datadir --configdir --library There is no directions on good/best development practices (container ?). This is what I did. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2849?email_source=notifications&email_token=AD43NRWXD24TULGXU5XBKL3QGKIT5A5CNFSM4IK4RQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CURNA#issuecomment-524634292>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD43NRQR3O4U6ZCTVIAYXTLQGKIT5ANCNFSM4IK4RQ5Q>.

[lesnake]

That means that I have to tidy-up my development environment because the problems occurs on lines that I have not modified to make my function ... but which are indeed modified !

[mdebooy]

Let me know when I can pull your changes and I will retry the compilation. Op 26-08-19 om 21:42 schreef lesnake:

…

That means that I have to tidy-up my development environment because the problems occurs on lines that I have not modified to make my function ... but which are indeed modified ! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2849?email_source=notifications&email_token=AD43NRWDJYM6IZEGDFBPGWDQGQW3ZA5CNFSM4IK4RQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5FOKLQ#issuecomment-525002030>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD43NRULIP3P335QE7YCWB3QGQW3ZANCNFSM4IK4RQ5Q>.

[lesnake]

It should be good now. I made my branch from the wrong starting point when getting into the git process.

[mdebooy]

It now compiles (a few warnings about ISO C90 forbids variable length array ‘r’ [-Wvla]) and starts but it fails to run after asking to do a configuration. Does not matter if I accept or not. Guess that my parameters are not correct. I will try to sort it out tomorrow. booymar@farao:/srv/local/Marco/myDarktable/bin/bin$ ./darktable --datadir /srv/local/Marco/myDarktable/data --configdir /srv/local/Marco/myDarktable/config --library /srv/local/Marco/myDarktable/bin/lib/darktable [defaults] found a 64-bit system with 15330844 kb ram and 4 cores (0 atom based) [defaults] setting high quality defaults [init] could not find database `darktable'! [init] maybe your /srv/local/Marco/myDarktable/config/darktablerc is corrupt? [init] try `cp /srv/local/Marco/myDarktable/data/darktablerc /srv/local/Marco/myDarktable/config/darktablerc' ERROR : cannot open database booymar@farao:/srv/local/Marco/myDarktable/bin/bin$ Op 27-08-19 om 21:56 schreef lesnake:

…

It should be good now. I made my branch from the wrong starting point when getting into the git process. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2849?email_source=notifications&email_token=AD43NRVKP3COYNCDYHTPV7LQGWBGFA5CNFSM4IK4RQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5I5TVA#issuecomment-525457876>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD43NRQOCFMBS4J62526PUTQGWBGFANCNFSM4IK4RQ5Q>.

[lesnake]

I had to struggle a bit for configuration.
I configured the build to install in a subdirectory named "prefix", in which I created data and config dirs. share subdir is created by install process.
I think that populating data with pixmaps, rawspeed directories and darktablerc file. All are can be found in the share subdirectory

Here is my full command line :
prefix/bin/darktable --datadir /home/pierre/Build/dt-numeric-crop-ctrl/prefix/data --configdir /home/pierre/Build/dt-numeric-crop-ctrl/prefix/config --moduledir /home/pierre/Build/dt-numeric-crop-ctrl/prefix/lib/darktable/ --localedir /home/pierre/Build/dt-numeric-crop-ctrl/prefix/share/local

As I wrote, I had to try hard, so some info may be missing.