Lua Translation remaining tasks #531
Conversation
|
Fixed |
name string instead of the filename
tools/script_manager - change get_script_metadata to retreive a
script metadata block and store it as a
metadata block making the indiviual fields
accessible.
change the script buttons to use the translated
name if available and just the purpose for the
tooltip.
|
@TurboGit latest commit makes the button name use the translated metadata block name. I only did official/apply_camera_stryle as a test so I need to give the rest of the scripts real_names (not just the filename) and make them translatable. |
removing underscores, spelling out abbreviations, etc.
|
Made all the script names into names that are translatable. Except for |
cleaned up metadata handling (trimmed whitespace and comments) fixed bug with folder names partially matching other folder names
|
Added translated folder names. That should be the last item. @TurboGit do you want to play with it or do you want me to merge and push? |
|
Just tested, it is better but I have some new issues:
The menu in Scripts is translated:
(See Fusion avec enfuse) But when I activated the module I get in dt module list:
That is the title of the module could be using the translated label maybe? And the whole interface is not translated. |
I was grabbing the metadata block as just text and formatting it for display as a tooltip. Now I actually grab the block and put it in a table so that I can use the individual fields (name is now translated and used for the button text, purpose is now the tooltip, author isn't currently used, and help should eventually get coupled to a shortcut so that the webpage can be opened). The tooltip can show whatever information we want it to. I can add more fields to the metadata if we need to. For now I just made it purpose, so it's a "real" tooltip, but I'm open to suggestions. EDIT:
Fixed. I just missed it. I was so focused on fixing the existing stuff I over looked the missing stuff. |
|
Went through and found the other libs that didn't have the module name translated |
|
I'll do another pass on this soon and will report back. Thanks for the hard work! |
All good to me, please do a new PR to update the Lua submodule. Thanks! |
|
@TurboGit , the lua-scripts submodule doesn't show up in a fresh clone of master. Did something change? |
|
Missing the recursive clone ? Now you can just: |
|
not sure why the directories containing the scripts in script manager should be translated - if "examples" is translated then i'd expected the directory path to be translated too - but that isnÄ't done on initial installation of scripts |
|
I'm not sure I understand what you mean. Where are you seeing the directory path untranslated? Or, are you talking about the physical directory on disk? The translation of directory names is done internally in script_manager. The goal of script_manager is to hide the implementation details from the user since the original method of using the scripts (editing a luarc file) was deemed too difficult by the masses and a barrier to entry. For now the directory names are used more or less (contrib is now contributed even in English). The next step is to have user defined categories so the users can arrange the scripts into categories that make sense to them. At that point the physical layout of the scripts and the logical layout of the scripts will be completely separated. |
|
@TurboGit the lua-scripts submodule got removed in 8a312fbaf464defcb8c8f44f309b156f01715503. Found it with a bisect. a312fbaf464defcb8c8f44f309b156f01715503 is the first bad commit src/external/lua-scripts | 1 - EDIT: Should I close the PR that I submitted and that has a conflict because of the above and then just add the submodule with new master in another PR? |
|
Yes, just found about this this morning. Now fixed. |
Final fixes to Lua translation being handled by darktable.
Fixes darktable-org/darktable#17699.