Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Conversation

technohippy
Copy link
Contributor

regard data-ng-attr as ng-attr

See. #519

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

void

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added.

@mhevery
Copy link
Contributor

mhevery commented Feb 15, 2014

Can you address the comments before I can merge it.

mhevery pushed a commit to mhevery/angular.dart that referenced this pull request Feb 15, 2014
mhevery pushed a commit to mhevery/angular.dart that referenced this pull request Feb 15, 2014
regard data-ng-attr as ng-attr

See. dart-archive#519
@technohippy
Copy link
Contributor Author

I resolved conflicts and rebased.

@mhevery
Copy link
Contributor

mhevery commented Feb 19, 2014

As currently implemented we iterate over the element attributes multiple times.

  1. in compile
  2. once during selector normalization
  3. and once in NodeAttrs.

DOM access of any kind is slow, and I think this would make our compilation 3 times slower.

Also we are changing the DOM structure.

I think a better approach is to just leave the attributes on node as is and don't try to change them. Instead have Selector ignore the data- prefix and have the compiler built up a mapping which is passed to NodeAttrs which says that if someone is reading from foo they really are reading from data-foo.

@technohippy
Copy link
Contributor Author

OK. You're right. I'll do another try.

technohippy added a commit to technohippy/angular.dart that referenced this pull request Feb 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants