This repository was archived by the owner on Feb 22, 2018. It is now read-only.
feat(selector): attribute normalization #603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regard data-ng-attr as ng-attr See. dart-archive#519, dart-archive#560
There was a problem hiding this comment.
We should not be special casing ng- any attribute can have a data- not just ng-
There was a problem hiding this comment.
This means users cannot define their own directive using a data- attribute as a selector. Is it a spec that all data-foo attributes are taken as foo attributes in all directive selectors?
|
Maybe it is better that we eliminate all data- prefixes at compile time if possible and allowed. |
|
we are doing some compiler refactoring and I think this change will be easier once that happens. |
|
Closing for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regard data-ng-attr as ng-attr
See. #519, #560