add support for _embedder.yaml file #1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,7 +129,7 @@ class DartDoc { | |||
| List<LibraryElement> _parseLibraries(List<String> files) { | |||
| Set<LibraryElement> libraries = new Set(); | |||
| DartSdk sdk = new DirectoryBasedDartSdk(new JavaFile(sdkDir.path)); | |||
There was a problem hiding this comment.
You might consider moving SDK creation into the else block in case there is embedder information and it isn't needed?
There was a problem hiding this comment.
It is used otherwise too.
There was a problem hiding this comment.
If that's the case, we need an EmbedderSdk in case there's embedded SDK info...
Maybe better to discuss in person?
|
LGTM % nits. |
keertip
added a commit
that referenced
this pull request
Feb 17, 2016
add support for _embedder.yaml file
| @@ -0,0 +1,4 @@ | |||
| embedder_libs: | |||
There was a problem hiding this comment.
This has changed. It's now embedded_libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1067
@pq , currently using an alpha version of the analyzer. Will wait till a new version is released to land this.