upgrade the html package dep #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why we have the .pubspec.lock file committed into the repo. Shouldn't this be .gitignored, and not in the repo? If it is common practice to include this file, then OK, but I didn't think it was. |
|
Previous best practice was to commit the .lock file for apps. Libraries should not have a .lock file committed. Maybe that's changed? |
|
Eric says that in general, the pubspec.lock should be committed in the repo for applications, but not for libraries. But I suppose it doesn't hurt anything for a library - things using the library wouldn't even see it. |
|
I'm confused - dartdoc is an app; per conventions we should be checking in the lock file, no? |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keertip @whesse