Optimize peak heap usage #1858
Merged
Optimize peak heap usage #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles in time for empty packages
jcollins-g
requested review from
bwilkerson and
stereotype441
and removed request for
stereotype441 and
bwilkerson
|
@bwilkerson can you review this? |
|
This is now ready for review. I recommend using this link to show the differences from #1851. |
bwilkerson
approved these changes
Dec 4, 2018
lib/src/model.dart
Outdated
| @@ -10,6 +10,7 @@ import 'dart:collection' show UnmodifiableListView; | |||
| import 'dart:convert'; | |||
| import 'dart:io'; | |||
|
|
|||
| import 'package:analyzer/analyzer.dart'; | |||
There was a problem hiding this comment.
This library is deprecated and will hopefully be removed soon. Please replace this import with imports of more specific libraries, even if they are private libraries.
lib/src/model.dart
Outdated
| class _HashableChildLibraryElementVisitor | ||
| extends GeneralizingElementVisitor<void> { | ||
| final void Function(Element) libraryProcessor; | ||
| _HashableChildLibraryElementVisitor(this.libraryProcessor) {} |
There was a problem hiding this comment.
style nit: consider replacing "{}" with ";" (here and elsewhere)
lib/src/model.dart
Outdated
| @@ -6652,7 +6722,7 @@ class PackageBuilder { | |||
| } | |||
| } | |||
| } while (!lastPass.containsAll(current)); | |||
| return libraries; | |||
| return; | |||
There was a problem hiding this comment.
style nit: consider removing this line
lib/src/model_utils.dart
Outdated
| @@ -7,6 +7,7 @@ library dartdoc.model_utils; | |||
| import 'dart:convert'; | |||
| import 'dart:io'; | |||
|
|
|||
| import 'package:analyzer/analyzer.dart'; | |||
There was a problem hiding this comment.
Please also replace this import.
|
Going to land this by force-landing #1851 and then doing the git dance to land this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing/landing purposes, this includes #1851, but is only different from that PR by the final 3 commits, starting with: 2afd621.
While this eliminates some extra traversal of ResolvedUnitResults and saves on peak memory, the cost is a slightly more complicated PackageGraph initialization that requires some callbacks in getLibraries.