Skip to content

Optimize peak heap usage #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Dec 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
acf94af
asynchronous PackageGraph construction and precaching
jcollins-g Nov 21, 2018
90ff17f
checkpoint
bwilkerson Nov 20, 2018
d8b7f90
cleanup
bwilkerson Nov 21, 2018
ca819a4
checkpoint
bwilkerson Nov 26, 2018
950335c
Run tools more asynchronously
jcollins-g Nov 26, 2018
939ea12
Enhacements and dropping of Future.wait
jcollins-g Nov 26, 2018
8719bbe
dartfmt
jcollins-g Nov 26, 2018
af10438
Rate-limit the number of tools in flight
jcollins-g Nov 26, 2018
8ac2bf9
checkpoint
bwilkerson Nov 27, 2018
0f3d477
Workaround for duplicate ResovledLibraryResult objects
jcollins-g Nov 27, 2018
c2a41ba
Merge branch 'remove-computeNode' into packageGraph-async+remove-comp…
jcollins-g Nov 27, 2018
71fabb2
Patch up merge problem and rebuild test package docs
jcollins-g Nov 27, 2018
37ec146
Use maps to avoid having to filter results
jcollins-g Nov 27, 2018
4654ed1
Merge branch 'master' into packageGraph-async
jcollins-g Nov 27, 2018
f23c82d
dartfmt and review comments
jcollins-g Nov 27, 2018
0336b6c
Merge branch 'packageGraph-async' into packageGraph-async+remove-comp…
jcollins-g Nov 27, 2018
a76ce6f
Update test package docs again (quotation marks different in stable b…
jcollins-g Nov 27, 2018
8386579
Merge branch 'master' into packageGraph-async
jcollins-g Nov 27, 2018
ed75c6d
Merge branch 'packageGraph-async' into packageGraph-async+remove-comp…
jcollins-g Nov 27, 2018
5509b4f
Clear pubspec overrides (this will only work in sdk-analyzer Travis)
jcollins-g Nov 28, 2018
a60e5e5
Change sdk test branch to master (analyzer-0.33 not integrated yet)
jcollins-g Nov 28, 2018
b9dea86
Merge branch 'master' into packageGraph-async+remove-computeNode
jcollins-g Nov 28, 2018
c8fe92a
Set correct analyzer version
jcollins-g Nov 28, 2018
e2ff8f5
Eliminate initialization race where analyzer might not find all the f…
jcollins-g Nov 28, 2018
90e8712
Update analyzer requirement
jcollins-g Nov 29, 2018
443ebe8
Merge branch 'master' into packageGraph-async+remove-computeNode
jcollins-g Nov 30, 2018
7835cd1
Merge branch 'master' into packageGraph-async+remove-computeNode
jcollins-g Nov 30, 2018
b83db86
Merge branch 'master' into packageGraph-async+remove-computeNode
jcollins-g Nov 30, 2018
88c67be
Fix merge error
jcollins-g Nov 30, 2018
2afd621
Optimize peak heap usage
jcollins-g Dec 1, 2018
620fd34
Fix bug in library count
jcollins-g Dec 1, 2018
7ac903a
Fix embedder and refactor file generation
jcollins-g Dec 3, 2018
7866418
Review comments
jcollins-g Dec 4, 2018
67c6f26
Merge branch 'master' into packageGraph-async+remove-computeNode
jcollins-g Dec 4, 2018
74ce51c
Merge branch 'packageGraph-async+remove-computeNode' into pga+rc+remo…
jcollins-g Dec 4, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/dartdoc.dart
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,15 @@ class Dartdoc extends PackageBuilder {

seconds = _stopwatch.elapsedMilliseconds / 1000.0;
logInfo(
"Documented ${packageGraph.publicLibraries.length} public librar${packageGraph.publicLibraries.length == 1 ? 'y' : 'ies'} "
"Documented ${packageGraph.localPublicLibraries.length} public librar${packageGraph.localPublicLibraries.length == 1 ? 'y' : 'ies'} "
"in ${seconds.toStringAsFixed(1)} seconds");
return new DartdocResults(
config.topLevelPackageMeta, packageGraph, outputDir);
}

Future<DartdocResults> generateDocs() async {
DartdocResults dartdocResults = await generateDocsBase();
if (dartdocResults.packageGraph.publicLibraries.isEmpty) {
if (dartdocResults.packageGraph.localPublicLibraries.isEmpty) {
throw new DartdocFailure(
"dartdoc could not find any libraries to document");
}
Expand Down
Loading