Skip to content

rev to 0.2.2 #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2015
Merged

rev to 0.2.2 #723

merged 1 commit into from
Jul 23, 2015

Conversation

devoncarew
Copy link
Member

@sethladd, I plan to push out what we have now (to capture the NPE fix).

@sethladd
Copy link
Contributor

Please squash commits :)

Or, are you going to use the git reflow tool which I think will squash for you?

@sethladd sethladd added this to the 0.2.2 milestone Jul 23, 2015
@devoncarew
Copy link
Member Author

so much squashing

@sethladd
Copy link
Contributor

You also want this in your pre-commit hook:

#!/bin/sh

dartfiles=$(git diff --cached --name-only --diff-filter=ACM | grep '.dart$')
[ -z "$dartfiles" ] && exit 0

unformatted=$(dartfmt -n $dartfiles)
[ -z "$unformatted" ] && exit 0

echo >&2 "Dart files must be formatted with dartfmt. Please run:"
for fn in $unformatted; do
    echo >&2 "  dartfmt -w $PWD/$fn"
done

exit 1

Then, no more dartfmt commits :)

devoncarew added a commit that referenced this pull request Jul 23, 2015
@devoncarew devoncarew merged commit ba79e47 into master Jul 23, 2015
@kevmoo kevmoo deleted the devoncarew_0.2.2 branch July 23, 2015 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants