Add link checker to build, and disable hrefs for inherited methods/properties/operators #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add a link checker for the CI build
sethladd
changed the title
|
Addresses #749 |
| @@ -12,6 +12,8 @@ import 'package:grinder/grinder.dart'; | |||
| import 'package:librato/librato.dart'; | |||
| import 'package:path/path.dart' as path; | |||
| import 'package:yaml/yaml.dart' as yaml; | |||
| import 'package:html/parser.dart' show parse; | |||
There was a problem hiding this comment.
can haz analyzer quick fix? :P
|
Also addresses #751 |
|
Also addresses #752 |
|
OK @devoncarew please take a look. This is a doosy. It closes out numerous issues, adds more tests, adds a link checker. Does it make sense to add the link checker to the Windows build bot? lgtm |
|
lgtm!
Could be good, esp.if there are path issues we'd only see there. |
OK, will do! (looks like the Windows bot is driven off of grinder) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.