Tiny fix: A top-level declaration pair (same basename) must be a getter and a setter #1594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section 'Class Member Conflicts' specifies several conflicts (we can't have a method and a setter with the same basename, etc), but similar rules are missing for top-level declarations.
Only one of these rules is relevant (there are no top-level constructors so we can't have a conflict at the top level involving a constructor, etc.): It is an error to have a setter with basename
n
together with any other declaration with basenamen
, except when that other declaration is a getter.This PR adds that rule.
Update: The rule in 'Class Member Conflicts' about setter/method conflicts was a bit vague: It referred to "member" with the intent that it should cover both static and instance members. It is now split into two sentences where one says 'the interface of$C$ contains an instance member' respectively '$C$ declares a static member'. The static/instance and instance/static cases are already covered by the previous sentence.
There is no associated implementation work, this behavior is already implemented.