Skip to content

[native_toolchain_c] Add a default Logger #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

[native_toolchain_c] Add a default Logger #2661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ec668
[native_toolchain_c] Add a default `Logger`
dcharkes Sep 30, 2025
6238487
add comment
dcharkes Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions pkgs/code_assets/example/mini_audio/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import 'package:code_assets/code_assets.dart';
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> args) async {
Expand All @@ -20,13 +19,7 @@ void main(List<String> args) async {
'MA_API': '__declspec(dllexport)',
},
);
await builder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) => print(record.message)),
);
await builder.run(input: input, output: output);
}
});
}
9 changes: 1 addition & 8 deletions pkgs/code_assets/example/sqlite/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import 'package:code_assets/code_assets.dart';
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> args) async {
Expand All @@ -20,13 +19,7 @@ void main(List<String> args) async {
'SQLITE_API': '__declspec(dllexport)',
},
);
await builder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) => print(record.message)),
);
await builder.run(input: input, output: output);
}
});
}
9 changes: 1 addition & 8 deletions pkgs/code_assets/example/stb_image/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import 'package:code_assets/code_assets.dart';
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> args) async {
Expand All @@ -20,13 +19,7 @@ void main(List<String> args) async {
'STBIDEF': '__declspec(dllexport)',
},
);
await builder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) => print(record.message)),
);
await builder.run(input: input, output: output);
}
});
}
9 changes: 1 addition & 8 deletions pkgs/hooks/example/api/build_snippet_1.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

// snippet-start
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> args) async {
Expand All @@ -19,13 +18,7 @@ void main(List<String> args) async {
assetName: '$packageName.dart',
sources: ['src/$packageName.c'],
);
await cbuilder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) => print(record.message)),
);
await cbuilder.run(input: input, output: output);
});
}

Expand Down
9 changes: 1 addition & 8 deletions pkgs/hooks/example/api/builder_snippet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

// snippet-start
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> args) async {
Expand All @@ -19,13 +18,7 @@ void main(List<String> args) async {
assetName: '$packageName.dart',
sources: ['src/$packageName.c'],
);
await cbuilder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) => print(record.message)),
);
await cbuilder.run(input: input, output: output);
});
}

Expand Down
9 changes: 1 addition & 8 deletions pkgs/hooks/example/build/download_asset/lib/src/hook_helpers/c_build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import 'package:code_assets/code_assets.dart';
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

/// Builds the C code for the native_add example.
Expand All @@ -21,13 +20,7 @@ Future<void> runBuild(BuildInput input, BuildOutputBuilder output) async {
assetName: 'native_add.dart',
sources: ['src/native_add.c'],
);
await cbuilder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) => print(record.message)),
);
await cbuilder.run(input: input, output: output);
}

/// Creates a target name based on the OS, architecture, and iOS SDK.
Expand Down
9 changes: 1 addition & 8 deletions pkgs/hooks/example/build/native_add_library/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// BSD-style license that can be found in the LICENSE file.

import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> args) async {
Expand All @@ -14,12 +13,6 @@ void main(List<String> args) async {
assetName: '$packageName.dart',
sources: ['src/$packageName.c'],
);
await cbuilder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) => print(record.message)),
);
await cbuilder.run(input: input, output: output);
});
}
7 changes: 1 addition & 6 deletions pkgs/hooks/example/build/native_dynamic_linking/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,10 @@
// BSD-style license that can be found in the LICENSE file.

import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> args) async {
await build(args, (input, output) async {
final logger = Logger('')
..level = Level.ALL
..onRecord.listen((record) => print(record.message));

final builders = [
CBuilder.library(
name: 'debug',
Expand All @@ -35,7 +30,7 @@ void main(List<String> args) async {
// Note: These builders need to be run sequentially because they depend on
// each others output.
for (final builder in builders) {
await builder.run(input: input, output: output, logger: logger);
await builder.run(input: input, output: output);
}
});
}
11 changes: 1 addition & 10 deletions pkgs/hooks/example/build/use_dart_api/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// BSD-style license that can be found in the LICENSE file.

import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> arguments) async {
Expand All @@ -14,14 +13,6 @@ void main(List<String> arguments) async {
assetName: 'src/${packageName}_bindings_generated.dart',
sources: ['src/$packageName.c', 'src/dart_api_dl.c'],
);
await cbuilder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) {
print('${record.level.name}: ${record.time}: ${record.message}');
}),
);
await cbuilder.run(input: input, output: output);
});
}
9 changes: 1 addition & 8 deletions pkgs/hooks/lib/src/api/build_and_link.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import '../validation.dart';
/// <!-- file://./../../../example/api/build_snippet_1.dart -->
/// ```dart
/// import 'package:hooks/hooks.dart';
/// import 'package:logging/logging.dart';
/// import 'package:native_toolchain_c/native_toolchain_c.dart';
///
/// void main(List<String> args) async {
Expand All @@ -34,13 +33,7 @@ import '../validation.dart';
/// assetName: '$packageName.dart',
/// sources: ['src/$packageName.c'],
/// );
/// await cbuilder.run(
/// input: input,
/// output: output,
/// logger: Logger('')
/// ..level = Level.ALL
/// ..onRecord.listen((record) => print(record.message)),
/// );
/// await cbuilder.run(input: input, output: output);
/// });
/// }
/// ```
Expand Down
9 changes: 1 addition & 8 deletions pkgs/hooks/lib/src/api/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import 'linker.dart';
/// <!-- file://./../../../example/api/builder_snippet.dart -->
/// ```dart
/// import 'package:hooks/hooks.dart';
/// import 'package:logging/logging.dart';
/// import 'package:native_toolchain_c/native_toolchain_c.dart';
///
/// void main(List<String> args) async {
Expand All @@ -37,13 +36,7 @@ import 'linker.dart';
/// assetName: '$packageName.dart',
/// sources: ['src/$packageName.c'],
/// );
/// await cbuilder.run(
/// input: input,
/// output: output,
/// logger: Logger('')
/// ..level = Level.ALL
/// ..onRecord.listen((record) => print(record.message)),
/// );
/// await cbuilder.run(input: input, output: output);
/// });
/// }
/// ```
Expand Down
7 changes: 0 additions & 7 deletions pkgs/hooks_runner/test_data/add_asset_link/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,13 @@

import 'package:code_assets/code_assets.dart';
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> arguments) async {
await build(arguments, (input, output) async {
if (!input.config.linkingEnabled) {
throw Exception('Link hook must be run!');
}
final logger = Logger('')
..level = Level.ALL
..onRecord.listen((record) {
print('${record.level.name}: ${record.time}: ${record.message}');
});
await CBuilder.library(
name: 'add',
assetName: 'dylib_add_build',
Expand All @@ -25,7 +19,6 @@ void main(List<String> arguments) async {
).run(
input: input,
output: output,
logger: logger,
routing: const [ToLinkHook('add_asset_link')],
);
});
Expand Down
10 changes: 2 additions & 8 deletions pkgs/hooks_runner/test_data/drop_dylib_link/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,10 @@

import 'package:code_assets/code_assets.dart';
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> arguments) async {
await build(arguments, (input, output) async {
final logger = Logger('')
..level = Level.ALL
..onRecord.listen((record) {
print('${record.level.name}: ${record.time}: ${record.message}');
});
final routing = input.config.linkingEnabled
? <AssetRouting>[ToLinkHook(input.packageName)]
: [const ToAppBundle()];
Expand All @@ -22,13 +16,13 @@ void main(List<String> arguments) async {
assetName: 'dylib_add',
sources: ['src/native_add.c'],
linkModePreference: LinkModePreference.dynamic,
).run(input: input, output: output, logger: logger, routing: routing);
).run(input: input, output: output, routing: routing);

await CBuilder.library(
name: 'multiply',
assetName: 'dylib_multiply',
sources: ['src/native_multiply.c'],
linkModePreference: LinkModePreference.dynamic,
).run(input: input, output: output, logger: logger, routing: routing);
).run(input: input, output: output, routing: routing);
});
}
11 changes: 1 addition & 10 deletions pkgs/hooks_runner/test_data/native_add/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import 'dart:io';

import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> arguments) async {
Expand All @@ -16,15 +15,7 @@ void main(List<String> arguments) async {
assetName: 'src/${packageName}_bindings_generated.dart',
sources: ['src/$packageName.c'],
);
await cbuilder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) {
print('${record.level.name}: ${record.time}: ${record.message}');
}),
);
await cbuilder.run(input: input, output: output);
stdout.writeln('Some stdout.');
stderr.writeln('Some stderr.');
});
Expand Down
11 changes: 1 addition & 10 deletions pkgs/hooks_runner/test_data/native_add_add_source/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// BSD-style license that can be found in the LICENSE file.

import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> arguments) async {
Expand All @@ -14,14 +13,6 @@ void main(List<String> arguments) async {
assetName: '${packageName}_bindings_generated.dart',
sources: ['src/$packageName.c', 'src/native_multiply.c'],
);
await cbuilder.run(
input: input,
output: output,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) {
print('${record.level.name}: ${record.time}: ${record.message}');
}),
);
await cbuilder.run(input: input, output: output);
});
}
11 changes: 1 addition & 10 deletions pkgs/hooks_runner/test_data/native_add_duplicate/hook/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import 'package:code_assets/code_assets.dart';
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';

void main(List<String> arguments) async {
Expand All @@ -18,15 +17,7 @@ void main(List<String> arguments) async {
);
// Temp output to prevent outputting the dylib for bundling.
final outputBuilder = BuildOutputBuilder();
await cbuilder.run(
input: input,
output: outputBuilder,
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) {
print('${record.level.name}: ${record.time}: ${record.message}');
}),
);
await cbuilder.run(input: input, output: outputBuilder);
final tempBuildOutput = outputBuilder.build();
output.assets.code.add(
tempBuildOutput.assets.code.single,
Expand Down
Loading
Loading