Skip to content

Conversation

dcharkes
Copy link
Collaborator

Bug:

The log level is defaulted to INFO. Looking at various places in the code base that's a desired level. However, we could consider also swapping it to WARNING.

Side note: Maybe we'll have less logging messages once we support a dedicated progress update:

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:code_assets 0.19.7 already published at pub.dev
package:data_assets 0.19.3 already published at pub.dev
package:ffi 2.1.5-wip WIP (no publish necessary)
package:hooks 0.20.1 already published at pub.dev
package:hooks_runner 0.23.0 already published at pub.dev
package:native_doc_dartifier 0.0.1-pre already published at pub.dev
package:native_toolchain_c 0.17.2 ready to publish native_toolchain_c-v0.17.2
package:swift2objc 0.1.0 already published at pub.dev
package:swiftgen 0.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Sep 30, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
code_assets None 0.19.7 0.19.7 0.19.7 ✔️
hooks None 0.20.1 0.20.1 0.20.1 ✔️
hooks_runner None 0.23.0 0.23.0 0.23.0 ✔️
native_toolchain_c None 0.17.1 0.17.2 0.17.1 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Sep 30, 2025

Coverage Status

coverage: 80.834% (-9.2%) from 90.022%
when pulling 6238487 on ntc-logger
into 400c700 on main.

Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleans up the call sites nicly!

LGTM

required BuildInput input,
required BuildOutputBuilder output,
required Logger? logger,
Logger? logger,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some information to the doc comment about default logging behavior and how to change it?

Copy link

auto-submit bot commented Oct 1, 2025

autosubmit label was removed for dart-lang/native/2661, because - The status or check suite build (macos, stable) has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite build (macos, dev) has failed. Please fix the issues identified (or deflake) before re-applying this label.

Future<void> run({
required BuildInput input,
required BuildOutputBuilder output,
required Logger? logger,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed too?

(Asking since I’m currently implementing this interface and was wondering haha)

Copy link
Collaborator Author

@dcharkes dcharkes Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should. (It's a pity we can't provide a default on the interface itself, so every implementer needs to provide the same sensible default.) I have on my list to make that change and update package:native_toolchain_c.

@auto-submit auto-submit bot merged commit 3ec5735 into main Oct 1, 2025
61 of 67 checks passed
@auto-submit auto-submit bot deleted the ntc-logger branch October 1, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants