-
Notifications
You must be signed in to change notification settings - Fork 80
[native_toolchain_c] Add a default Logger
#2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleans up the call sites nicly!
LGTM
required BuildInput input, | ||
required BuildOutputBuilder output, | ||
required Logger? logger, | ||
Logger? logger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some information to the doc comment about default logging behavior and how to change it?
autosubmit label was removed for dart-lang/native/2661, because - The status or check suite build (macos, stable) has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Future<void> run({ | ||
required BuildInput input, | ||
required BuildOutputBuilder output, | ||
required Logger? logger, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be changed too?
(Asking since I’m currently implementing this interface and was wondering haha)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should. (It's a pity we can't provide a default on the interface itself, so every implementer needs to provide the same sensible default.) I have on my list to make that change and update package:native_toolchain_c
.
Bug:
Logger
argument behavior #2645The log level is defaulted to
INFO
. Looking at various places in the code base that's a desired level. However, we could consider also swapping it toWARNING
.Side note: Maybe we'll have less logging messages once we support a dedicated progress update: