Skip to content

Conversation

goderbauer
Copy link
Contributor

Part of #2645.
Modeled after #2661.

Main motivation is to simplify the example given in the new readme (less boilerplate, fewer dependencies to add): #2691

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@@ -1,3 +1,8 @@
## 20.0.0-dev.1-wip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20.0.1-wip ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 20.0.0 hasn't been release yet (it has only been release as a -dev prerelease) I think this change will ultimately go out as part of the 20.0.0 release - and not 20.0.1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, then it should just be 20.0.0-wip so we don't need to number on changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's release this as 20.0.0-dev.1 so we can remove the logger from the other examples.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@coveralls
Copy link

coveralls commented Oct 13, 2025

Coverage Status

coverage: 81.215% (-0.05%) from 81.265%
when pulling 4233dc3 on goderbauer:ffigenlogger
into c4b4950 on dart-lang:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants