-
Notifications
You must be signed in to change notification settings - Fork 80
[ffigen] make logger optional #2694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
pkgs/ffigen/CHANGELOG.md
Outdated
@@ -1,3 +1,8 @@ | |||
## 20.0.0-dev.1-wip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20.0.1-wip ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since 20.0.0 hasn't been release yet (it has only been release as a -dev prerelease) I think this change will ultimately go out as part of the 20.0.0 release - and not 20.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, then it should just be 20.0.0-wip so we don't need to number on changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, let's release this as 20.0.0-dev.1 so we can remove the logger from the other examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
4233dc3
to
8d25b2b
Compare
Part of #2645.
Modeled after #2661.
Main motivation is to simplify the example given in the new readme (less boilerplate, fewer dependencies to add): #2691