Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test.dart does not correctly read client.status for client/touch test. #1040

Closed
whesse opened this issue Jan 4, 2012 · 2 comments
Closed

test.dart does not correctly read client.status for client/touch test. #1040

whesse opened this issue Jan 4, 2012 · 2 comments
Assignees
@whesse
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@whesse
Copy link
Contributor

whesse commented Jan 4, 2012

The client/touch test fails, but test.py reports a success:
If you run

tools/test.py --mode=release -cfrogium client/touch --verbose --keep_temporary_files

then it reports success, but if you run the command line printed by this test, then two out of three tests fail. Here is the command line:

[your dart checkout]/client/tests/drt/DumpRenderTree --no-timeout "--dart-flags=--enable_asserts --enable_type_checks --ignore-unrecognized-flags" [your dart checkout]/client/out/Release_ia32/client_tests_client_touch_touch_tests.dart.html
@whesse
Copy link
Contributor Author

whesse commented Jan 4, 2012

The test is supposed to fail, and is marked that way in the client.status file. test.py is reading the status correctly, and test.dart is not finding the status for that test correctly.

Set owner to @whesse.
Removed Area-Frog label.
Added Area-Test, Accepted labels.
Changed the title to: "test.dart does not correctly read client.status for client/touch test.".

@whesse
Copy link
Contributor Author

whesse commented Jan 5, 2012

Fixed in r2990, http://codereview.chromium.org//9111010

Added Fixed label.

@whesse whesse added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Jan 5, 2012
@whesse whesse self-assigned this Jan 5, 2012
copybara-service bot pushed a commit that referenced this issue Nov 13, 2023
@devoncarew
[deps] rev boolean_selector, browser_launcher, http, leak_tracker, te…
d44d923 
…st, tools

Revisions updated by `dart tools/rev_sdk_deps.dart`.

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7f523c3..caea8d4):
  caea8d4  2023-11-09  Kevin Moore  Require Dart 3.1, bump and fix lints, use switch expressions (#55)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/4f9e784..f60df1d):
  f60df1d  2023-11-09  Kevin Moore  Update and fix lints, require Dart 3.0 (#53)

http (https://github.com/dart-lang/http/compare/a2f3c1d..f0a02f9):
  f0a02f9  2023-11-09  Brian Quinlan  Require a package:jni version without known buffer overflows (#1044)
  b2717ba  2023-11-06  Brian Quinlan  Create a flutter example application that uses multiple client implementations (#1040)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/d3c9060..a618a55):
  a618a55  2023-11-13  Polina Cherkasova  Update pubspec.yaml (#184)
  1e05c4d  2023-11-13  Polina Cherkasova  Separate web implementation for retaining path. (#183)
  53f04a8  2023-11-08  Polina Cherkasova  Debug information should not wipe other settings. (#182)
  fbc2014  2023-11-06  Devon Carew  use package:lints/recommended.yaml generally (#180)

test (https://github.com/dart-lang/test/compare/075faff..8ba0940):
  8ba0940d  2023-11-10  Nate Bosch  Strip leading slash when spawning isolate (#2136)

tools (https://github.com/dart-lang/tools/compare/dd46ef2..2e36b8d):
  2e36b8d  2023-11-13  Leigha Jarett  Modify titles (#196)
  68b4e6b  2023-11-13  Elias Yishak  Add enum + event constructor for code size analysis (#200)

Change-Id: If39fa9f3bdf7c6195c3ac91fb60a0987d4b70920
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335841
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whesse