Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need access to compilation results from the editor #105

Closed
bwilkerson opened this issue Oct 13, 2011 · 2 comments
Closed

Need access to compilation results from the editor #105

bwilkerson opened this issue Oct 13, 2011 · 2 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug type-performance Issue relates to performance or code size

Comments

@bwilkerson
Copy link
Member

The editor is currently having to parse and resolve every modified file twice, once as part of doing a full compile (in the builder) and once when building the index. We would like to have an API defined that would allow us to avoid duplicating this effort.

Two proposals have been suggested. The first is to add a method like unitCompiled(Source, DartUnit) to DartCompilerListener that would provide the Source and DartUnit of each AST that has been fully compiled as part of compiling a given library. The method needs to be invoked after the AST has been fully resolved. It also needs to be guaranteed that the AST represents (to the greatest extent possible in the face of syntactic errors) the actual structure of the original source code (that is, it cannot be normalized in place or otherwise altered) and that it will not be changed (other than in well defined ways, such as setting the normalizedNode) after the method is invoked.

The second proposal is to have the method DartCompiler.compileLib(LibrarySource, CompilerConfiguration, DartArtifactProvider, DartCompilerListener) return a CompilationResult rather than a simple String and for this object to have accessor methods that return the equivalent information.

My preference is for the first option because then the editor can potentially use the AST structure (in a read-only fashion) at the same time that the compiler is proceeding on multi-processor machines, reducing the overall compile time.

@jtmcdole
Copy link
Contributor

Looking into the first option now.

@jtmcdole
Copy link
Contributor

Added Fixed label.

@bwilkerson bwilkerson added Type-Enhancement P1 A high priority bug; for example, a single project is unusable or has many test failures type-performance Issue relates to performance or code size labels Oct 14, 2011
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
nex3 pushed a commit that referenced this issue Aug 31, 2016
Fixes #105

This overlaps with brian's recent CL moving override inference logic.  If this looks good, we'll need to move it over as well.

R=brianwilkerson@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/1311863005 .
copybara-service bot pushed a commit that referenced this issue Oct 4, 2023
…ctor, browser_launcher, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, lints, logging, markdown, matcher, mime, mockito, native, package_config, path, pool, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, typed_data, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/5a4e16f..df9b428):
  df9b428  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#256)
  892f013  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#257)

async (https://github.com/dart-lang/async/compare/75efa6c..def4482):
  def4482  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#253)
  a0ca552  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#252)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/159e671..b1b6a66):
  b1b6a66  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#82)
  bb9e48d  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#81)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/7d0d28e..59aea95):
  59aea95  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#94)
  e3f6207  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#93)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/f255921..9431e01):
  9431e01  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#51)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/1f69393..25bc94a):
  25bc94a  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#50)

cli_util (https://github.com/dart-lang/cli_util/compare/44118e3..9e48f0d):
  9e48f0d  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#90)

clock (https://github.com/dart-lang/clock/compare/1e75f08..200a020):
  200a020  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#56)
  8a2b550  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#57)

collection (https://github.com/dart-lang/collection/compare/91afde4..d27bfaf):
  d27bfaf  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#314)
  5d568ae  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#313)

convert (https://github.com/dart-lang/convert/compare/c058c8f..140b2f0):
  140b2f0  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#87)

crypto (https://github.com/dart-lang/crypto/compare/1e26879..b38dd62):
  b38dd62  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153)

csslib (https://github.com/dart-lang/csslib/compare/bd30a1a..f6b68dd):
  f6b68dd  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#190)
  4b1ee3f  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#189)

dartdoc (https://github.com/dart-lang/dartdoc/compare/a3cfdc4..59947b1):
  59947b14  2023-09-25  Sam Rawlins  Do not hide stacktrace of DartdocFailures (#3505)
  d95af5c7  2023-09-25  dependabot[bot]  Bump actions/checkout from 4.0.0 to 4.1.0 (#3506)

ecosystem (https://github.com/dart-lang/ecosystem/compare/3da2dd3..dcbd2ee):
  dcbd2ee  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#184)
  3006120  2023-10-01  dependabot[bot]  Bump peter-evans/create-or-update-comment (#183)
  69334aa  2023-10-01  dependabot[bot]  Bump actions/upload-artifact (#181)
  3dd6c69  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#185)
  2c5523c  2023-10-01  dependabot[bot]  Bump actions/cache from 3.3.1 to 3.3.2 (#182)
  5b7d3fd  2023-09-28  Devon Carew  update package:dart_flutter_team_lints to use the beta package:lints (#179)
  297e63e  2023-09-28  Devon Carew  fix an issue validating pre-release git publishing tags (#180)
  1154183  2023-09-28  Moritz  Check for `DO_NOT_SUBMIT` strings. (#178)
  bc2dd27  2023-09-28  Moritz  Add api tool call for testing (#153)
  eb8e398  2023-09-27  Moritz  Do not fail `publish` on forks (#177)
  f40a4eb  2023-09-25  Devon Carew  improve support for '-dev' and '-wip' package versions (#173)

ffi (https://github.com/dart-lang/ffi/compare/d36e05a..ee70dd4):
  ee70dd4  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#214)

fixnum (https://github.com/dart-lang/fixnum/compare/87ed065..ef0a587):
  ef0a587  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#115)

glob (https://github.com/dart-lang/glob/compare/9c1996f..0046533):
  0046533  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#83)
  f6ebc74  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#84)

html (https://github.com/dart-lang/html/compare/a1b193e..49e2c8e):
  49e2c8e  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#228)
  fb2de8a  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#227)

http (https://github.com/dart-lang/http/compare/1251619..88ec75e):
  88ec75e  2023-10-01  dependabot[bot]  Bump actions/checkout from 3 to 4 (#1025)
  08143d1  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#1024)
  2c99da1  2023-10-01  dependabot[bot]  Bump actions/cache from 3.3.1 to 3.3.2 (#1023)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/9d62ea3..03041aa):
  03041aa  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#59)
  5efaa07  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#58)

http_parser (https://github.com/dart-lang/http_parser/compare/d2d03e7..c557f57):
  c557f57  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#78)
  a629fd6  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#79)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/50a3786..0521afb):
  0521afb  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#104)
  4782145  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103)

lints (https://github.com/dart-lang/lints/compare/b044aca..140c802):
  140c802  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#158)
  624a09d  2023-09-28  Devon Carew  add dangling_library_doc_comments, remove prefer_void_to_null (#157)
  296efaf  2023-09-28  Devon Carew  remove no_wildcard_variable_uses; improve testing (#156)
  c266a04  2023-09-26  Devon Carew  rev to 3.0.0-beta in preparation for publishing (#153)

logging (https://github.com/dart-lang/logging/compare/bcaad0f..642ed21):
  642ed21  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#149)
  287f4cb  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#148)

markdown (https://github.com/dart-lang/markdown/compare/6cfd6f1..ae766d5):
  ae766d5  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#556)

matcher (https://github.com/dart-lang/matcher/compare/80910d6..11daad9):
  11daad9  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#229)

mime (https://github.com/dart-lang/mime/compare/37ef637..f3b9c49):
  f3b9c49  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#105)

mockito (https://github.com/dart-lang/mockito/compare/097e563..610c3dc):
  610c3dc  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#699)
  73930cd  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#698)

native (https://github.com/dart-lang/native/compare/be4aaf7..22500ea):
  22500ea  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#144)
  5bfc7ff  2023-10-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#145)
  0b7885a  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#143)

package_config (https://github.com/dart-lang/package_config/compare/ae7ad83..100533d):
  100533d  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#141)
  a4b474a  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#142)

path (https://github.com/dart-lang/path/compare/96d9183..abcf38c):
  abcf38c  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#151)

pool (https://github.com/dart-lang/pool/compare/a5bee35..4bcc7de):
  4bcc7de  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#75)

pub_semver (https://github.com/dart-lang/pub_semver/compare/f0be74a..8e5a58f):
  8e5a58f  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#93)
  81da7c8  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#92)

shelf (https://github.com/dart-lang/shelf/compare/4851978..c15fc6f):
  c15fc6f  2023-10-01  dependabot[bot]  Bump actions/cache from 3.3.1 to 3.3.2 (#386)
  e47c00e  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#384)
  b9c898e  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#385)
  9b96b9b  2023-09-26  Michael Thomsen  Add backend tag in pubspec.yaml (#381)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/196d7bf..73d449c):
  73d449c  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#42)
  2c4840e  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#43)

source_maps (https://github.com/dart-lang/source_maps/compare/eb3d40a..fc6aa16):
  fc6aa16  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#83)
  dfca7d5  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#82)

source_span (https://github.com/dart-lang/source_span/compare/48d0f57..92e50bf):
  92e50bf  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#102)
  c212afa  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103)

sse (https://github.com/dart-lang/sse/compare/eeb2588..606387e):
  606387e  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#89)

stack_trace (https://github.com/dart-lang/stack_trace/compare/bcf2a0b..1c36cd7):
  1c36cd7  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#143)

stream_channel (https://github.com/dart-lang/stream_channel/compare/0ce7ab6..bf74065):
  bf74065  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#95)

string_scanner (https://github.com/dart-lang/string_scanner/compare/da9142c..616424c):
  616424c  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#63)

term_glyph (https://github.com/dart-lang/term_glyph/compare/1b28285..19abf84):
  19abf84  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#42)

test (https://github.com/dart-lang/test/compare/8191a35..367aa39):
  367aa397  2023-10-02  Jacob MacDonald  release test_core and test (#2112)
  672be9d7  2023-10-02  Ben Konyi  Update package:vm_service to 12.0.0 (#2110)
  de324cc7  2023-10-01  dependabot[bot]  Bump github/codeql-action from 2.21.5 to 2.21.9 (#2106)
  31b94dbb  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#2105)
  d56c2150  2023-10-01  dependabot[bot]  Bump actions/cache from 3.0.11 to 3.3.2 (#2108)
  b93f1b50  2023-10-01  dependabot[bot]  Bump actions/upload-artifact from 3.1.2 to 3.1.3 (#2109)
  a077b673  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#2107)
  566d70a2  2023-09-26  Lau Ching Jun  Filter test by line when kernel is compiled with --filesystem-scheme. (#2101)
  7ec1bbf5  2023-09-25  Nate Bosch  Drop support for legacy iframe communication (#2099)
  d3f4b368  2023-09-25  Nate Bosch  Tighten types in test utils (#2097)
  9d997910  2023-09-25  Nate Bosch  Add types to Browser implementation url arguments (#2096)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/030193d..55b5eac):
  55b5eac  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#57)
  c2ba59e  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#56)

test_process (https://github.com/dart-lang/test_process/compare/2a6ee23..5efd0bf):
  5efd0bf  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#49)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/45c57d6..8593eb1):
  8593eb1  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#52)
  4857e22  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#53)

tools (https://github.com/dart-lang/tools/compare/3c248df..f318c80):
  f318c80  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#177)
  0480655  2023-10-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#176)
  73583e8  2023-09-29  Devon Carew  update package:cli_config to the latest package:dart_flutter_team_lints (#171)
  b293897  2023-09-28  Devon Carew  update to the latest package:dart_flutter_team_lints (#173)
  242fdb5  2023-09-28  Devon Carew  update to the latest package:dart_flutter_team_lints (#172)
  a51f779  2023-09-28  Elias Yishak  Use constant for no op client id (#168)
  e83caee  2023-09-27  Moritz  Allow `publish` to write comments on forks (#169)

typed_data (https://github.com/dart-lang/typed_data/compare/80e8943..d1c15ed):
  d1c15ed  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#73)
  e13af06  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#74)

usage (https://github.com/dart-lang/usage/compare/7b12d51..d7d2964):
  d7d2964  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#198)
  920c6e8  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#199)

watcher (https://github.com/dart-lang/watcher/compare/1aed03e..c480e2d):
  c480e2d  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#151)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/af945f1..364013d):
  364013d  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#286)
  50dada7  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#285)

webdev (https://github.com/dart-lang/webdev/compare/3078f48..7c2c2d7):
  7c2c2d70  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 4.1.0 (#2245)
  7739a114  2023-09-26  Elliott Brooks  Refactor tests to handle new `ToolConfiguration` (#2243)
  4e350cde  2023-09-21  Elliott Brooks  Fix issue with the inspector panel in the Dart Debug Extension (#2242)
  bbddba29  2023-09-21  Elliott Brooks  Prepare the Dart Debug Extension for release to version 1.36 (#2241)
  cc5db13f  2023-09-21  Elliott Brooks  Rename plainUri to debugUri and send it to the extension (#2238)
  48fc725f  2023-09-20  Elliott Brooks  Add a new workspaceName parameter to DWDS on start up (#2237)
  d2dae560  2023-09-20  Elliott Brooks  Refactor: Update the parameters for `DWDS.start` (#2231)

yaml (https://github.com/dart-lang/yaml/compare/ae00187..9f0d649):
  9f0d649  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153)
  8e70ffb  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#152)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/4a9734d..a7e7fba):
  a7e7fba  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#58)
  f33e3d0  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#59)
  8a380e8  2023-09-28  Sigurd Meldgaard  Change AliasError to AliasException (#57)

Change-Id: I22f88e36d2eceb03495dabcf1265e9043364e0bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329260
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
…, convert, crypto, csslib, ecosystem, ffi, file, fixnum, html, http, lints, logging, markdown, matcher, mime, native, path, pool, protobuf, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test_descriptor, test_process, test_reflective_loader, tools, typed_data, watcher, web_socket_channel, webdriver, webkit_inspection_protocol, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/def4482..9924570):
  9924570  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#255)
  61cdb0f  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#254)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/479e1c1..7f523c3):
  7f523c3  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#53)
  1ed2941  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#54)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/c2871b2..4f9e784):
  4f9e784  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#51)
  706c031  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#52)

cli_util (https://github.com/dart-lang/cli_util/compare/56c1235..500dffa):
  500dffa  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#91)
  c66e201  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#92)

clock (https://github.com/dart-lang/clock/compare/200a020..f975668):
  f975668  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#59)
  eb5d2f5  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#58)

convert (https://github.com/dart-lang/convert/compare/03242b2..f24afa7):
  f24afa7  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#89)
  a3e9bc5  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#90)

crypto (https://github.com/dart-lang/crypto/compare/36ead7c..f3e64d2):
  f3e64d2  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#155)
  7a7b517  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#156)

csslib (https://github.com/dart-lang/csslib/compare/f6b68dd..17346e5):
  17346e5  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#191)
  4bdc553  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#192)

ecosystem (https://github.com/dart-lang/ecosystem/compare/4acfcaf..dda7886):
  dda7886  2023-11-01  dependabot[bot]  Bump peter-evans/create-or-update-comment (#192)
  b681c56  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#193)
  0d768d4  2023-11-01  dependabot[bot]  Bump subosito/flutter-action from 2.10.0 to 2.12.0 (#190)
  178d244  2023-11-01  dependabot[bot]  Bump actions/github-script (#194)
  4b3e572  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#191)

ffi (https://github.com/dart-lang/ffi/compare/2faec28..c926657):
  c926657  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#219)
  3181ec0  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#220)

file (https://github.com/google/file.dart/compare/7418131..e7c03aa):
  e7c03aa  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#233)

fixnum (https://github.com/dart-lang/fixnum/compare/ef45eb5..3279f5d):
  3279f5d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#120)
  4913894  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#121)

html (https://github.com/dart-lang/html/compare/49e2c8e..06bc148):
  06bc148  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#232)
  2630607  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#233)

http (https://github.com/dart-lang/http/compare/7240d0a..b9389fe):
  b9389fe  2023-11-01  dependabot[bot]  Bump futureware-tech/simulator-action from 2 to 3 (#1037)
  d7c36ae  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#1038)

lints (https://github.com/dart-lang/lints/compare/5c60f48..f58fd77):
  f58fd77  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#168)

logging (https://github.com/dart-lang/logging/compare/642ed21..324a0b5):
  324a0b5  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#150)
  e9b13b7  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#151)

markdown (https://github.com/dart-lang/markdown/compare/4e2e970..efb73b3):
  efb73b3  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#561)
  2e4a3bc  2023-11-01  dependabot[bot]  Bump subosito/flutter-action from 2.10.0 to 2.11.0 (#559)
  22e378b  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#560)

matcher (https://github.com/dart-lang/matcher/compare/7512f80..3d03fa1):
  3d03fa1  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#231)
  b7d24c8  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#232)

mime (https://github.com/dart-lang/mime/compare/af3e5fe..8ebf946):
  8ebf946  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#108)
  4328d32  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#107)

native (https://github.com/dart-lang/native/compare/279094d..de9d59e):
  de9d59e  2023-11-01  Daco Harkes  [infra] Fix PR publisher comments (#177)
  22b6b24  2023-11-01  Daco Harkes  [infra] Rename `dart.yaml` to `native.yaml` (#176)
  cc42fb1  2023-11-01  Daco Harkes  [native_toolchain_c] Use sysroot on Android (#180)
  01d92b0  2023-11-01  Daco Harkes  [native_toolchain_c] Bump highest tested NDK version to 34 (#182)
  53facde  2023-11-01  Daco Harkes  [native_toolchain_c] Fix NDK discovery (#179)
  285ee6c  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#174)
  46a05e4  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#172)
  23187fe  2023-11-01  dependabot[bot]  Bump nttld/setup-ndk from 1.3.1 to 1.4.1 (#173)

path (https://github.com/dart-lang/path/compare/4ca27d4..18ec71f):
  18ec71f  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#153)
  f26c20c  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#154)

pool (https://github.com/dart-lang/pool/compare/5ccef15..c78cef4):
  c78cef4  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#76)

protobuf (https://github.com/dart-lang/protobuf/compare/3f567b2..dcec2ed):
  dcec2ed  2023-10-31  Ömer Sinan Ağacan  Annotate deepCopy with @useResult (#897)

pub_semver (https://github.com/dart-lang/pub_semver/compare/8e5a58f..f9e94ee):
  f9e94ee  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#95)
  81fdbcf  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#94)

shelf (https://github.com/dart-lang/shelf/compare/c15fc6f..b3adc7c):
  b3adc7c  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#391)
  baea52d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#392)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/73d449c..2209626):
  2209626  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#45)
  bfa3949  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#44)

source_maps (https://github.com/dart-lang/source_maps/compare/fc6aa16..87dc587):
  87dc587  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#84)
  33ba11d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#85)

source_span (https://github.com/dart-lang/source_span/compare/92e50bf..ed16e0d):
  ed16e0d  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#105)
  aacd748  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#104)

sse (https://github.com/dart-lang/sse/compare/37df57d..8ddb95f):
  8ddb95f  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#95)
  8830125  2023-11-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.2.0 to 2.2.1 (#94)
  86dd8f9  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#93)

stack_trace (https://github.com/dart-lang/stack_trace/compare/634589f..6496ff8):
  6496ff8  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#145)
  3d60304  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#144)

stream_channel (https://github.com/dart-lang/stream_channel/compare/ffdb208..178104d):
  178104d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#98)
  1193387  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#97)

string_scanner (https://github.com/dart-lang/string_scanner/compare/9c525f7..a7105ef):
  a7105ef  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#65)
  f33ca6f  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#66)

term_glyph (https://github.com/dart-lang/term_glyph/compare/cff80de..7c1eb9d):
  7c1eb9d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#45)
  39073ca  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#44)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/55b5eac..c417cbb):
  c417cbb  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#59)
  dcfde39  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#58)

test_process (https://github.com/dart-lang/test_process/compare/d610333..c21e40d):
  c21e40d  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#51)
  bfd0576  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#50)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/8593eb1..17d40bb):
  17d40bb  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#54)
  e664092  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#55)

tools (https://github.com/dart-lang/tools/compare/01c0b52..dd91cb6):
  dd91cb6  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#192)
  603b012  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#191)

typed_data (https://github.com/dart-lang/typed_data/compare/d1c15ed..0b16bd2):
  0b16bd2  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#76)
  f869102  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#77)

watcher (https://github.com/dart-lang/watcher/compare/6ad58dc..b2b278a):
  b2b278a  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#154)
  97e9637  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#155)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/f3ac1bf..82ac73f):
  82ac73f  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#289)
  3615850  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#290)

webdriver (https://github.com/google/webdriver.dart/compare/eaf9c58..43ed1db):
  43ed1db  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#289)
  02fd658  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#288)
  8828360  2023-11-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.2.0 to 2.2.1 (#287)

webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/82f0c1c..2c6f8b6):
  2c6f8b6  2023-11-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.1 (#114)
  d4e4d55  2023-11-01  dependabot[bot]  Bump nanasess/setup-chromedriver from 2.2.0 to 2.2.1 (#115)

yaml (https://github.com/dart-lang/yaml/compare/9f0d649..98a3aab):
  98a3aab  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#154)
  b63372b  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#155)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/a7e7fba..9b9d33c):
  9b9d33c  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#61)
  b71c2e8  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#60)

Change-Id: I8b663f536d4e80728c6570372d886edfef227cf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333059
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 2, 2023
…lob, http_multi_server, http_parser, json_rpc_2, mockito, native, package_config, pool, sync_http, usage, webkit_inspection_protocol

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/df9b428..46d5033):
  46d5033  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#258)
  5f7c8b5  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#259)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/b1b6a66..3d9cd58):
  3d9cd58  2023-11-02  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#83)
  1d7bed3  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#84)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/59aea95..e59f675):
  e59f675  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#96)
  1899e39  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#95)

collection (https://github.com/dart-lang/collection/compare/d27bfaf..e8d7e92):
  e8d7e92  2023-11-02  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#318)
  1f5c234  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#319)

file (https://github.com/google/file.dart/compare/e7c03aa..cd3a932):
  cd3a932  2023-11-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.1 (#232)

glob (https://github.com/dart-lang/glob/compare/0046533..7c9a121):
  7c9a121  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#86)
  713142b  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#85)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/03041aa..2238a6b):
  2238a6b  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#60)

http_parser (https://github.com/dart-lang/http_parser/compare/c557f57..1cf5b7c):
  1cf5b7c  2023-11-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#80)
  cb6f142  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#81)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/0521afb..460545c):
  460545c  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#105)
  189b1a8  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#106)

mockito (https://github.com/dart-lang/mockito/compare/b7d752e..fcb9779):
  fcb9779  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#713)
  1c4a6ff  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#712)

native (https://github.com/dart-lang/native/compare/de9d59e..c72ed16):
  c72ed16  2023-11-01  Daco Harkes  [native_toolchain_c] Bump version to 0.3.2 (#184)
  4c9a50f  2023-11-01  Daco Harkes  [native_toolchain_c] Add workaround for minSdkVersion 19 and 20 (#181)
  45b5e6c  2023-11-01  Daco Harkes  [infra] Bump NDK version (#183)

package_config (https://github.com/dart-lang/package_config/compare/100533d..33dd246):
  33dd246  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#144)
  30c8f25  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#143)

pool (https://github.com/dart-lang/pool/compare/c78cef4..3c1bd42):
  3c1bd42  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#77)

sync_http (https://github.com/dart-lang/sync_http/compare/8233f74..d8e9f3d):
  d8e9f3d  2023-11-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.1 (#40)
  c59b6d4  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#41)

usage (https://github.com/dart-lang/usage/compare/d7d2964..e99690a):
  e99690a  2023-11-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#201)
  a540a6d  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#200)

webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/2c6f8b6..667c55e):
  667c55e  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#113)

Change-Id: Ie6f2f0df0060cd77b9d56dc40172c134605417e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug type-performance Issue relates to performance or code size
Projects
None yet
Development

No branches or pull requests

3 participants