Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are spec bugs in break and continue statements #143

Closed
DartBot opened this issue Oct 17, 2011 · 6 comments
Closed

There are spec bugs in break and continue statements #143

DartBot opened this issue Oct 17, 2011 · 6 comments
Assignees
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).

Comments

@DartBot
Copy link

DartBot commented Oct 17, 2011

This issue was originally filed by boos...@gmail.com


What steps will reproduce the problem?
1.compile and run following code
main()
{
a : { break a ; }
b : { continue b ; }
}
2.
3.

What is the expected output? What do you see instead?

If the specification is correct.
first statement:
a : { break b ; }
is well-formed and run without any error.
break statement terminate the execution of block statement.

second statement:
b : { continue b ; }
is well-formed and run without any error.
continue statement transfers control to the label statement which cause infinite loop.

This is true if the current spec wording is correct.
But I suspect this is a bug of the spec.

What version of the product are you using? On what operating system?
Dart Programming Language Speci cation Draft Version 0.02
I tried code via http://try.dartlang.org/

Please provide any additional information below.

@floitschG
Copy link
Contributor

Added Area-Language, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Oct 17, 2011

This comment was originally written by jat@google.com


Why is it a bug in the spec any more than while(true) {} is an infinite loop? There are an infinite number of ways to write an infinite loop, and the language spec should not be in the business of deciding which of them is correct.

@floitschG
Copy link
Contributor

No. This is a bug in the spec. 'continue label' should only be allowed for labels that are on loopy constructs or on switch clauses.

@DartBot
Copy link
Author

DartBot commented Oct 17, 2011

This comment was originally written by boostc...@gmail.com


when I tried it in http://try.dartlang.org/
break statement works just as I expected.
continue statement passes the compile, but cause strange run time error.

@gbracha
Copy link
Contributor

gbracha commented Oct 18, 2011

Set owner to @gbracha.
Added Accepted label.

@gbracha
Copy link
Contributor

gbracha commented Jan 25, 2012

break is fine; continue was wrong. Fixed in 0.08 draft.


Added Done label.

@DartBot DartBot added Type-Defect area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Jan 25, 2012
pq added a commit that referenced this issue Nov 10, 2015
Pulls in:

* Added `prefer_is_not_empty` lint rule (#143).
* Added `type_annotate_public_apis` lint rule (#24).
* Added `avoid_as` lint rule (#145).
* Fixed `non_constant_identifier_names` rule to special case underscore identifiers in callbacks.
* Fix to escape `_`s in callback type validation (addresses false positives in `always_specify_types`) (#147).

R=keertip@google.com

Review URL: https://codereview.chromium.org/1434773002 .
copybara-service bot pushed a commit that referenced this issue May 17, 2022
Changes:
```
> git log --format="%C(auto) %h %s" 4dd3242..0c8364a
 https://dart.googlesource.com/ffi.git/+/0c8364a Update README.md (#143)
 https://dart.googlesource.com/ffi.git/+/fea40a9 Revert "Common C integer types (#128)" (#141)
 https://dart.googlesource.com/ffi.git/+/c4c59e8 Update pubspec.yaml (#139)
 https://dart.googlesource.com/ffi.git/+/d81d1b7 Bump version to 1.2.0 (#132)
 https://dart.googlesource.com/ffi.git/+/5a33a25 Enable and fix new strict analysis options (#131)
 https://dart.googlesource.com/ffi.git/+/5e801e8 Common C integer types (#128)

```

Diff: https://dart.googlesource.com/ffi.git/+/4dd32429880a57b64edaf54c9d5af8a9fa9a4ffb~..0c8364a728cfe4e4ba859c53b99d56b3dbe3add4/
Change-Id: Ie1d3e30030594a24fdece7408ae3687033f8e772
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244963
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Apr 4, 2023
…ctor, browser_launcher, characters, clock, collection, convert, crypto, csslib, dartdoc, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, logging, matcher, mime, package_config, path, pool, pub_semver, source_maps, source_span, sse, stack_trace, stream_channel, term_glyph, test, test_descriptor, test_process, tools, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/7a5e3b0..5ac2ba1):
  5ac2ba1  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#238)
  f77b1dc  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#239)

async (https://github.com/dart-lang/async/compare/f454380..0127813):
  0127813  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#236)
  100445b  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#237)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/53871c5..d5f8837):
  d5f8837  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#70)
  a8a55e6  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#71)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/725534a..e591ec4):
  e591ec4  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#86)
  38bf5b8  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#87)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/16e6ad3..28dc03d):
  28dc03d  2023-04-04  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#45)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/bc2dc4e..ba4e028):
  ba4e028  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#41)

characters (https://github.com/dart-lang/characters/compare/3281cc7..ba8d557):
  ba8d557  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#79)
  60cae68  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#80)

clock (https://github.com/dart-lang/clock/compare/984642e..93d9f56):
  93d9f56  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#48)

collection (https://github.com/dart-lang/collection/compare/30fd0f8..9db854d):
  9db854d  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#278)

convert (https://github.com/dart-lang/convert/compare/83886e3..8812e40):
  8812e40  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79)
  d28dc33  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#80)

crypto (https://github.com/dart-lang/crypto/compare/9efb888..8a03816):
  8a03816  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#143)

csslib (https://github.com/dart-lang/csslib/compare/d32bdd4..5836863):
  5836863  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#177)

dartdoc (https://github.com/dart-lang/dartdoc/compare/9be04e0..1a7952b):
  1a7952b1  2023-04-03  dependabot[bot]  Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#3382)

fixnum (https://github.com/dart-lang/fixnum/compare/f8379d9..92ec336):
  92ec336  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#108)
  f14fd19  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#109)

glob (https://github.com/dart-lang/glob/compare/f378dc8..eaa878b):
  eaa878b  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#73)
  c0c7e66  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#74)

html (https://github.com/dart-lang/html/compare/08643e9..57b747d):
  57b747d  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#209)
  51c9910  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#210)

http (https://github.com/dart-lang/http/compare/74f9d3d..ffb4438):
  ffb4438  2023-04-04  Brian Quinlan  Fix maxRedirects documentation to mention ClientException rather than RedirectException (#907)
  ad0e1cf  2023-04-03  Bahaa Fathi Yousef  Fix some spelling (#885)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/7bd190c..e0b5d35):
  e0b5d35  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#53)
  3bbaf22  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#52)

http_parser (https://github.com/dart-lang/http_parser/compare/b3b283b..bbe37dd):
  bbe37dd  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#70)
  f0527a8  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#71)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/aea3bea..5da2705):
  5da2705  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#94)
  d6ab373  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#95)

logging (https://github.com/dart-lang/logging/compare/abef371..787030a):
  787030a  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#133)
  be6a20e  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#134)

matcher (https://github.com/dart-lang/matcher/compare/61f4347..cb6b68c):
  cb6b68c  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#216)

mime (https://github.com/dart-lang/mime/compare/1a51be0..2d8496d):
  2d8496d  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#90)
  3b39378  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#91)

package_config (https://github.com/dart-lang/package_config/compare/74ac1cb..7e09db1):
  7e09db1  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#132)
  6dc4072  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#133)

path (https://github.com/dart-lang/path/compare/cd37179..23e3319):
  23e3319  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#140)

pool (https://github.com/dart-lang/pool/compare/338bfb4..650e5d3):
  650e5d3  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#66)

pub_semver (https://github.com/dart-lang/pub_semver/compare/c0e6ea7..860e3d8):
  860e3d8  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#82)
  12eca92  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#83)

source_maps (https://github.com/dart-lang/source_maps/compare/a112e98..0a4b030):
  0a4b030  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#76)
  e753fea  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#75)

source_span (https://github.com/dart-lang/source_span/compare/3951ba5..b739fbf):
  b739fbf  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#94)
  c6547c2  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#95)

sse (https://github.com/dart-lang/sse/compare/8c3efdc..11e83a0):
  11e83a0  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79)

stack_trace (https://github.com/dart-lang/stack_trace/compare/6ceb191..9c1b1c5):
  9c1b1c5  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#128)
  56a09db  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#129)

stream_channel (https://github.com/dart-lang/stream_channel/compare/fe0f5e4..74646ea):
  74646ea  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#88)

term_glyph (https://github.com/dart-lang/term_glyph/compare/d275a8f..f6856e2):
  f6856e2  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#36)

test (https://github.com/dart-lang/test/compare/a01b185..8ea4298):
  8ea42987  2023-04-04  Jakub Vrána  Make tests compatible with Strict CSP (#1987)
  49f7e17a  2023-04-03  dependabot[bot]  Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#1982)
  1a4f76b2  2023-04-03  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.9 (#1985)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/1d4a967..aa11162):
  aa11162  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49)
  226fe86  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#50)

test_process (https://github.com/dart-lang/test_process/compare/f76d0b8..946bc27):
  946bc27  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#40)
  441f585  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#41)

tools (https://github.com/dart-lang/tools/compare/d40ca93..0304fbb):
  0304fbb  2023-04-04  Elias Yishak  Add catcherror callback for `sendData` (#72)
  6d1dedf  2023-04-04  Daco Harkes  [cli_config] Pub badges (#71)
  561dce2  2023-04-04  Daco Harkes  [cli_config] Bump version (#68)
  d3909a4  2023-04-04  Daco Harkes  Fix windows path resolving (#67)
  77cf078  2023-04-03  Daco Harkes  [cli_config] Fix optionalString validValues (#69)

usage (https://github.com/dart-lang/usage/compare/399770f..0698711):
  0698711  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#190)
  2cdb5e3  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#189)

watcher (https://github.com/dart-lang/watcher/compare/5968409..00aa79b):
  00aa79b  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140)
  598038f  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#141)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/e2fe7f6..40eb236):
  40eb236  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#260)
  1823444  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#261)

webdev (https://github.com/dart-lang/webdev/compare/b139649..e887316):
  e887316c  2023-04-03  Elliott Brooks  Prepare DWDS for version `19.0.0` release (#2068)
  704d5086  2023-04-03  Elliott Brooks  Fix typo (#2069)
  2e6e1b63  2023-04-03  Anna Gringauze  Fix getObject failure on record class. (#2063)

yaml (https://github.com/dart-lang/yaml/compare/0f80b12..56dfaf4):
  56dfaf4  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140)
  d925d7e  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#141)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/fbc5cb3..386fd33):
  386fd33  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49)

Change-Id: I986c83f657631813a32e360fbb90f42f7d43440a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293280
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 4, 2023
…ctor, browser_launcher, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, lints, logging, markdown, matcher, mime, mockito, native, package_config, path, pool, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, typed_data, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/5a4e16f..df9b428):
  df9b428  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#256)
  892f013  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#257)

async (https://github.com/dart-lang/async/compare/75efa6c..def4482):
  def4482  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#253)
  a0ca552  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#252)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/159e671..b1b6a66):
  b1b6a66  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#82)
  bb9e48d  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#81)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/7d0d28e..59aea95):
  59aea95  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#94)
  e3f6207  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#93)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/f255921..9431e01):
  9431e01  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#51)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/1f69393..25bc94a):
  25bc94a  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#50)

cli_util (https://github.com/dart-lang/cli_util/compare/44118e3..9e48f0d):
  9e48f0d  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#90)

clock (https://github.com/dart-lang/clock/compare/1e75f08..200a020):
  200a020  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#56)
  8a2b550  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#57)

collection (https://github.com/dart-lang/collection/compare/91afde4..d27bfaf):
  d27bfaf  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#314)
  5d568ae  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#313)

convert (https://github.com/dart-lang/convert/compare/c058c8f..140b2f0):
  140b2f0  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#87)

crypto (https://github.com/dart-lang/crypto/compare/1e26879..b38dd62):
  b38dd62  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153)

csslib (https://github.com/dart-lang/csslib/compare/bd30a1a..f6b68dd):
  f6b68dd  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#190)
  4b1ee3f  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#189)

dartdoc (https://github.com/dart-lang/dartdoc/compare/a3cfdc4..59947b1):
  59947b14  2023-09-25  Sam Rawlins  Do not hide stacktrace of DartdocFailures (#3505)
  d95af5c7  2023-09-25  dependabot[bot]  Bump actions/checkout from 4.0.0 to 4.1.0 (#3506)

ecosystem (https://github.com/dart-lang/ecosystem/compare/3da2dd3..dcbd2ee):
  dcbd2ee  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#184)
  3006120  2023-10-01  dependabot[bot]  Bump peter-evans/create-or-update-comment (#183)
  69334aa  2023-10-01  dependabot[bot]  Bump actions/upload-artifact (#181)
  3dd6c69  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#185)
  2c5523c  2023-10-01  dependabot[bot]  Bump actions/cache from 3.3.1 to 3.3.2 (#182)
  5b7d3fd  2023-09-28  Devon Carew  update package:dart_flutter_team_lints to use the beta package:lints (#179)
  297e63e  2023-09-28  Devon Carew  fix an issue validating pre-release git publishing tags (#180)
  1154183  2023-09-28  Moritz  Check for `DO_NOT_SUBMIT` strings. (#178)
  bc2dd27  2023-09-28  Moritz  Add api tool call for testing (#153)
  eb8e398  2023-09-27  Moritz  Do not fail `publish` on forks (#177)
  f40a4eb  2023-09-25  Devon Carew  improve support for '-dev' and '-wip' package versions (#173)

ffi (https://github.com/dart-lang/ffi/compare/d36e05a..ee70dd4):
  ee70dd4  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#214)

fixnum (https://github.com/dart-lang/fixnum/compare/87ed065..ef0a587):
  ef0a587  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#115)

glob (https://github.com/dart-lang/glob/compare/9c1996f..0046533):
  0046533  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#83)
  f6ebc74  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#84)

html (https://github.com/dart-lang/html/compare/a1b193e..49e2c8e):
  49e2c8e  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#228)
  fb2de8a  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#227)

http (https://github.com/dart-lang/http/compare/1251619..88ec75e):
  88ec75e  2023-10-01  dependabot[bot]  Bump actions/checkout from 3 to 4 (#1025)
  08143d1  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#1024)
  2c99da1  2023-10-01  dependabot[bot]  Bump actions/cache from 3.3.1 to 3.3.2 (#1023)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/9d62ea3..03041aa):
  03041aa  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#59)
  5efaa07  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#58)

http_parser (https://github.com/dart-lang/http_parser/compare/d2d03e7..c557f57):
  c557f57  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#78)
  a629fd6  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#79)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/50a3786..0521afb):
  0521afb  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#104)
  4782145  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103)

lints (https://github.com/dart-lang/lints/compare/b044aca..140c802):
  140c802  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#158)
  624a09d  2023-09-28  Devon Carew  add dangling_library_doc_comments, remove prefer_void_to_null (#157)
  296efaf  2023-09-28  Devon Carew  remove no_wildcard_variable_uses; improve testing (#156)
  c266a04  2023-09-26  Devon Carew  rev to 3.0.0-beta in preparation for publishing (#153)

logging (https://github.com/dart-lang/logging/compare/bcaad0f..642ed21):
  642ed21  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#149)
  287f4cb  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#148)

markdown (https://github.com/dart-lang/markdown/compare/6cfd6f1..ae766d5):
  ae766d5  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#556)

matcher (https://github.com/dart-lang/matcher/compare/80910d6..11daad9):
  11daad9  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#229)

mime (https://github.com/dart-lang/mime/compare/37ef637..f3b9c49):
  f3b9c49  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#105)

mockito (https://github.com/dart-lang/mockito/compare/097e563..610c3dc):
  610c3dc  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#699)
  73930cd  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#698)

native (https://github.com/dart-lang/native/compare/be4aaf7..22500ea):
  22500ea  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#144)
  5bfc7ff  2023-10-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#145)
  0b7885a  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#143)

package_config (https://github.com/dart-lang/package_config/compare/ae7ad83..100533d):
  100533d  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#141)
  a4b474a  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#142)

path (https://github.com/dart-lang/path/compare/96d9183..abcf38c):
  abcf38c  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#151)

pool (https://github.com/dart-lang/pool/compare/a5bee35..4bcc7de):
  4bcc7de  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#75)

pub_semver (https://github.com/dart-lang/pub_semver/compare/f0be74a..8e5a58f):
  8e5a58f  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#93)
  81da7c8  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#92)

shelf (https://github.com/dart-lang/shelf/compare/4851978..c15fc6f):
  c15fc6f  2023-10-01  dependabot[bot]  Bump actions/cache from 3.3.1 to 3.3.2 (#386)
  e47c00e  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#384)
  b9c898e  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#385)
  9b96b9b  2023-09-26  Michael Thomsen  Add backend tag in pubspec.yaml (#381)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/196d7bf..73d449c):
  73d449c  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#42)
  2c4840e  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#43)

source_maps (https://github.com/dart-lang/source_maps/compare/eb3d40a..fc6aa16):
  fc6aa16  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#83)
  dfca7d5  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#82)

source_span (https://github.com/dart-lang/source_span/compare/48d0f57..92e50bf):
  92e50bf  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#102)
  c212afa  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#103)

sse (https://github.com/dart-lang/sse/compare/eeb2588..606387e):
  606387e  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#89)

stack_trace (https://github.com/dart-lang/stack_trace/compare/bcf2a0b..1c36cd7):
  1c36cd7  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#143)

stream_channel (https://github.com/dart-lang/stream_channel/compare/0ce7ab6..bf74065):
  bf74065  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#95)

string_scanner (https://github.com/dart-lang/string_scanner/compare/da9142c..616424c):
  616424c  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#63)

term_glyph (https://github.com/dart-lang/term_glyph/compare/1b28285..19abf84):
  19abf84  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#42)

test (https://github.com/dart-lang/test/compare/8191a35..367aa39):
  367aa397  2023-10-02  Jacob MacDonald  release test_core and test (#2112)
  672be9d7  2023-10-02  Ben Konyi  Update package:vm_service to 12.0.0 (#2110)
  de324cc7  2023-10-01  dependabot[bot]  Bump github/codeql-action from 2.21.5 to 2.21.9 (#2106)
  31b94dbb  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#2105)
  d56c2150  2023-10-01  dependabot[bot]  Bump actions/cache from 3.0.11 to 3.3.2 (#2108)
  b93f1b50  2023-10-01  dependabot[bot]  Bump actions/upload-artifact from 3.1.2 to 3.1.3 (#2109)
  a077b673  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#2107)
  566d70a2  2023-09-26  Lau Ching Jun  Filter test by line when kernel is compiled with --filesystem-scheme. (#2101)
  7ec1bbf5  2023-09-25  Nate Bosch  Drop support for legacy iframe communication (#2099)
  d3f4b368  2023-09-25  Nate Bosch  Tighten types in test utils (#2097)
  9d997910  2023-09-25  Nate Bosch  Add types to Browser implementation url arguments (#2096)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/030193d..55b5eac):
  55b5eac  2023-10-02  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#57)
  c2ba59e  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#56)

test_process (https://github.com/dart-lang/test_process/compare/2a6ee23..5efd0bf):
  5efd0bf  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#49)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/45c57d6..8593eb1):
  8593eb1  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#52)
  4857e22  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#53)

tools (https://github.com/dart-lang/tools/compare/3c248df..f318c80):
  f318c80  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#177)
  0480655  2023-10-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#176)
  73583e8  2023-09-29  Devon Carew  update package:cli_config to the latest package:dart_flutter_team_lints (#171)
  b293897  2023-09-28  Devon Carew  update to the latest package:dart_flutter_team_lints (#173)
  242fdb5  2023-09-28  Devon Carew  update to the latest package:dart_flutter_team_lints (#172)
  a51f779  2023-09-28  Elias Yishak  Use constant for no op client id (#168)
  e83caee  2023-09-27  Moritz  Allow `publish` to write comments on forks (#169)

typed_data (https://github.com/dart-lang/typed_data/compare/80e8943..d1c15ed):
  d1c15ed  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#73)
  e13af06  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#74)

usage (https://github.com/dart-lang/usage/compare/7b12d51..d7d2964):
  d7d2964  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#198)
  920c6e8  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#199)

watcher (https://github.com/dart-lang/watcher/compare/1aed03e..c480e2d):
  c480e2d  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#151)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/af945f1..364013d):
  364013d  2023-10-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#286)
  50dada7  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#285)

webdev (https://github.com/dart-lang/webdev/compare/3078f48..7c2c2d7):
  7c2c2d70  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 4.1.0 (#2245)
  7739a114  2023-09-26  Elliott Brooks  Refactor tests to handle new `ToolConfiguration` (#2243)
  4e350cde  2023-09-21  Elliott Brooks  Fix issue with the inspector panel in the Dart Debug Extension (#2242)
  bbddba29  2023-09-21  Elliott Brooks  Prepare the Dart Debug Extension for release to version 1.36 (#2241)
  cc5db13f  2023-09-21  Elliott Brooks  Rename plainUri to debugUri and send it to the extension (#2238)
  48fc725f  2023-09-20  Elliott Brooks  Add a new workspaceName parameter to DWDS on start up (#2237)
  d2dae560  2023-09-20  Elliott Brooks  Refactor: Update the parameters for `DWDS.start` (#2231)

yaml (https://github.com/dart-lang/yaml/compare/ae00187..9f0d649):
  9f0d649  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#153)
  8e70ffb  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#152)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/4a9734d..a7e7fba):
  a7e7fba  2023-10-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#58)
  f33e3d0  2023-10-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.5.1 (#59)
  8a380e8  2023-09-28  Sigurd Meldgaard  Change AliasError to AliasException (#57)

Change-Id: I22f88e36d2eceb03495dabcf1265e9043364e0bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329260
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Nov 2, 2023
…lob, http_multi_server, http_parser, json_rpc_2, mockito, native, package_config, pool, sync_http, usage, webkit_inspection_protocol

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/df9b428..46d5033):
  46d5033  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#258)
  5f7c8b5  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#259)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/b1b6a66..3d9cd58):
  3d9cd58  2023-11-02  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#83)
  1d7bed3  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#84)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/59aea95..e59f675):
  e59f675  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#96)
  1899e39  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#95)

collection (https://github.com/dart-lang/collection/compare/d27bfaf..e8d7e92):
  e8d7e92  2023-11-02  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#318)
  1f5c234  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#319)

file (https://github.com/google/file.dart/compare/e7c03aa..cd3a932):
  cd3a932  2023-11-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.1 (#232)

glob (https://github.com/dart-lang/glob/compare/0046533..7c9a121):
  7c9a121  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#86)
  713142b  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#85)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/03041aa..2238a6b):
  2238a6b  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#60)

http_parser (https://github.com/dart-lang/http_parser/compare/c557f57..1cf5b7c):
  1cf5b7c  2023-11-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#80)
  cb6f142  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#81)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/0521afb..460545c):
  460545c  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#105)
  189b1a8  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#106)

mockito (https://github.com/dart-lang/mockito/compare/b7d752e..fcb9779):
  fcb9779  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#713)
  1c4a6ff  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#712)

native (https://github.com/dart-lang/native/compare/de9d59e..c72ed16):
  c72ed16  2023-11-01  Daco Harkes  [native_toolchain_c] Bump version to 0.3.2 (#184)
  4c9a50f  2023-11-01  Daco Harkes  [native_toolchain_c] Add workaround for minSdkVersion 19 and 20 (#181)
  45b5e6c  2023-11-01  Daco Harkes  [infra] Bump NDK version (#183)

package_config (https://github.com/dart-lang/package_config/compare/100533d..33dd246):
  33dd246  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#144)
  30c8f25  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#143)

pool (https://github.com/dart-lang/pool/compare/c78cef4..3c1bd42):
  3c1bd42  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#77)

sync_http (https://github.com/dart-lang/sync_http/compare/8233f74..d8e9f3d):
  d8e9f3d  2023-11-01  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.1 (#40)
  c59b6d4  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#41)

usage (https://github.com/dart-lang/usage/compare/d7d2964..e99690a):
  e99690a  2023-11-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#201)
  a540a6d  2023-11-01  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#200)

webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/2c6f8b6..667c55e):
  667c55e  2023-11-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#113)

Change-Id: Ie6f2f0df0060cd77b9d56dc40172c134605417e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language).
Projects
None yet
Development

No branches or pull requests

3 participants