New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
native_BoolImplementation_EQ treats Boolean objects in a wrong way #79
Comments
This comment was originally written by andrea.giamm...@gmail.com function EQ(other) { |
This comment was originally written by andrea.giamma...@gmail.com ... and that should be called native_BoolImplementation_EQ I guess ... |
This comment was originally written by drfibonacci@google.com Set owner to mmendez@google.com. |
We should not need to look at "Boolean". The whole runtime only works with the primitive type. Furhermore, we might want to shortcut the equality test in EQ$Operator.(http://code.google.com/p/dart/source/browse/trunk/dart/compiler/lib/implementation/core.js) |
This comment was originally written by mmendez@google.com Set owner to johnle...@google.com. |
This comment was originally written by johnle...@google.com r456, I had been meaning clean this up for quite a while. Added Fixed label. |
Fix missing_return violation newly enforced in Dart ~2.3.2-dev.0.1
Changes: ``` > git log --format="%C(auto) %h %s" 2fa188c..405fc79 https://dart.googlesource.com/http_io.git/+/405fc79 Bump actions/checkout from 2 to 3 (#92) https://dart.googlesource.com/http_io.git/+/ccfb1ef Fix updated lints (#91) https://dart.googlesource.com/http_io.git/+/fcb94c0 Dart format with latest SDK (#90) https://dart.googlesource.com/http_io.git/+/b723cb6 Bump dart-lang/setup-dart from 0.3 to 1 (#89) https://dart.googlesource.com/http_io.git/+/ac00226 Add dependabot https://dart.googlesource.com/http_io.git/+/78956f5 Update LICENSE (#88) https://dart.googlesource.com/http_io.git/+/1715644 Migrate GitHub Actions (#86) https://dart.googlesource.com/http_io.git/+/5de81cd Update test API usage to non-deprecated members (#85) https://dart.googlesource.com/http_io.git/+/2cb230f Update formatting after dartfmt change https://dart.googlesource.com/http_io.git/+/c84afce test: remove unused, optional/positional argument in private function https://dart.googlesource.com/http_io.git/+/3adb2fd Fix lints (#81) https://dart.googlesource.com/http_io.git/+/e47fc8f lint cleanup (#80) https://dart.googlesource.com/http_io.git/+/5a3e178 Enable and fix lints (#79) https://dart.googlesource.com/http_io.git/+/771fb58 Bump min SDK for http_io (#78) https://dart.googlesource.com/http_io.git/+/fe5c4bf Fix return type in test functions https://dart.googlesource.com/http_io.git/+/0384af8 Travis: Update min tested SDK ``` Diff: https://dart.googlesource.com/http_io.git/+/2fa188caf7937e313026557713f7feffedd4978b~..405fc79233b4a3d4bb079ebf438bb2caf2f49355/ Change-Id: I1107e9dcdbb52bb3b22bd5abbcd347c5a83aea2d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244720 Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
…997897 Changes: ``` > git log --format="%C(auto) %h %s" dd6fb5d..e496577 https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/e496577 improve failure modes of ChromeConnection.getTabs (#88) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/49acd16 upgrade to lints 2.0.0 (#87) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/c34ebda rev to 1.0.1 (#84) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/950d52a Update README.md https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/3dd20cc Update README.md (#83) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/a79df73 depend on actions/checkout w/ a major version dep (#82) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/9ffbd21 Bump dart-lang/setup-dart from 1.0 to 1.3 (#81) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/dbc0fde Use more specific versions in the github action file (#79) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/092c910 Bump actions/checkout from 2 to 3 (#78) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/7156f1a Bump nanasess/setup-chromedriver from 1.0.5 to 1.0.7 (#77) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/920a381 configure dependabot (#76) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/73d61fa run tests in github actions (#74) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/8a3b2b3 Update README.md (#73) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/57ca5b0 enable the avoid_dynamic_calls lint (#72) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/d10f668 Use package lints (#70) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/da43164 add support for github actions (#69) https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/18620ab Delete .travis.yml ``` Diff: https://dart.googlesource.com/external/github.com/google/webkit_inspection_protocol.dart.git/+/dd6fb5d8b536e19cedb384d0bbf1f5631923f1e8~..e4965778e2837adc62354eec3a19123402997897/ Change-Id: I1052f9efedcb05e8dae815b926294ea6182c9560 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244941 Reviewed-by: Anna Gringauze <annagrin@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Merges shelf_router and shelf_router_generator to the shelf mono repo. Changes: ``` > git log --format="%C(auto) %h %s" fadca32..05f4260 https://dart.googlesource.com/shelf.git/+/05f4260 Merge remote-tracking branch 'origin/HEAD' into jonasfj/master https://dart.googlesource.com/shelf.git/+/4f4fa0a Fix pubspec repository for shelf_web_socket (#233) https://dart.googlesource.com/shelf.git/+/d4ff2ae Update READMEs, adjust mono_pkg.yaml https://dart.googlesource.com/shelf.git/+/d6efa6e Merge in shelf_router / shelf_router_generator. https://dart.googlesource.com/shelf.git/+/6d1f24d Add root readme (#229) https://dart.googlesource.com/shelf.git/+/d23cc89 Use the same lints across all packages (#228) https://dart.googlesource.com/shelf.git/+/3fdddb1 Merge CI steps across packages (#226) https://dart.googlesource.com/shelf.git/+/9b5a08a Upgrade mono_repo (#174) https://dart.googlesource.com/shelf.git/+/f04e60f Upgrade mono_repo (#169) https://dart.googlesource.com/shelf.git/+/ef1c1ae Merge pull request #165 from isoos/upgrade https://dart.googlesource.com/shelf.git/+/dc49716 bump version https://dart.googlesource.com/shelf.git/+/07bf70a Upgrade dependencies in shelf_router_generator https://dart.googlesource.com/shelf.git/+/640915e fix: mount remove trailing slash requirement (#146) https://dart.googlesource.com/shelf.git/+/138ca19 Migrate to pkg:lints (#161) https://dart.googlesource.com/shelf.git/+/d2d026b Bump mono_repo to v5.0.1 (#150) https://dart.googlesource.com/shelf.git/+/ac19cc9 Fix a number of hints and lints (#151) https://dart.googlesource.com/shelf.git/+/9cb612a shelf_router_generator: latest dependencies (#152) https://dart.googlesource.com/shelf.git/+/4947570 Fix SDK constraints 2.12.0-0 to 2.12.0 (#148) https://dart.googlesource.com/shelf.git/+/8a11fee Merge pull request #147 from isoos/fix-rnf https://dart.googlesource.com/shelf.git/+/789824d Fix Router.routeNotFound to enable multiple read() calls on it. https://dart.googlesource.com/shelf.git/+/fac496f Introduce `routeNotFound` sentinel for shelf_router 1.1.0 (#141) https://dart.googlesource.com/shelf.git/+/33206e9 remove handler from app (#131) https://dart.googlesource.com/shelf.git/+/02c49f7 remove handler from app (#129) https://dart.googlesource.com/shelf.git/+/12cd917 shelf_router_generator: Latest dependencies, null safety (#122) https://dart.googlesource.com/shelf.git/+/074341b Update dependencies and enable/fix a number of lints (#120) https://dart.googlesource.com/shelf.git/+/b094c25 shelf_router_generator: Support null-safe dependencies (#113) https://dart.googlesource.com/shelf.git/+/f07b3ef Prepare shelf_router 1.0.0 https://dart.googlesource.com/shelf.git/+/4c73784 Remove Router.handler while we're at it https://dart.googlesource.com/shelf.git/+/b18f808 Remove checkNotNull https://dart.googlesource.com/shelf.git/+/cce2ad9 Oops, forgot to set _params https://dart.googlesource.com/shelf.git/+/797da6e Avoid lazy in router entry https://dart.googlesource.com/shelf.git/+/a03e120 Make default handler customizable https://dart.googlesource.com/shelf.git/+/ed942ce No unecessary version bump, don't test on stable https://dart.googlesource.com/shelf.git/+/e18b186 [WIP] Migrate shelf_router to Dart null safety https://dart.googlesource.com/shelf.git/+/2a7cdd5 Upgrade package:analyzer in shelf_router_generator. https://dart.googlesource.com/shelf.git/+/6466748 Router: allow to mount a Handler (#86) https://dart.googlesource.com/shelf.git/+/91b695d Seal classes in shelf_router and prepare 0.7.3 (#85) https://dart.googlesource.com/shelf.git/+/4b4f15c Fix most of the hints - thanks to `dart fix` (#81) https://dart.googlesource.com/shelf.git/+/e99bcd0 Relax dependency constraint on analyzer for shelf_router_generator. (#79) https://dart.googlesource.com/shelf.git/+/2893dab Remove author from pubspec.yaml (#73) https://dart.googlesource.com/shelf.git/+/ac41ee2 Updated Travis configuration to allow packages to be tested in parallel jobs (#59) https://dart.googlesource.com/shelf.git/+/ad11925 Fix package:shelf_router to ensure GET handlers also respond to HEAD requests (#36) https://dart.googlesource.com/shelf.git/+/6a07835 Relax dependency on package:analyzer https://dart.googlesource.com/shelf.git/+/02e05dc Merge pull request #27 from jonasfj/relax-deps https://dart.googlesource.com/shelf.git/+/84fdb64 relax dependency constraint on analyzer https://dart.googlesource.com/shelf.git/+/aea3117 Merge pull request #19 from jonasfj/test-unrelated-annotation https://dart.googlesource.com/shelf.git/+/563e435 Test that unrelated annotations does not affect code-gen https://dart.googlesource.com/shelf.git/+/213d63a Prepare for releasing 0.7.2 https://dart.googlesource.com/shelf.git/+/910173d Add generated files https://dart.googlesource.com/shelf.git/+/d0e21d5 Added test case for string escaping https://dart.googlesource.com/shelf.git/+/663de80 Fix issue #10, use raw strings https://dart.googlesource.com/shelf.git/+/3a9cd9f Fix travis tests https://dart.googlesource.com/shelf.git/+/c7c3baf Use Function instead of dynamic for handler in shelf_router https://dart.googlesource.com/shelf.git/+/592fd64 Fixed #6, using Function instead of dynamic https://dart.googlesource.com/shelf.git/+/26e888f Bumped shelf_router_generator dependencies https://dart.googlesource.com/shelf.git/+/7622006 Updated shelf_router_generator README https://dart.googlesource.com/shelf.git/+/3aa13ea Fixing nits for shelf-router https://dart.googlesource.com/shelf.git/+/279af5d Prepared shelf_router_generator for initial release https://dart.googlesource.com/shelf.git/+/eb39128 Removed dependency overrides from shelf_router, and updated changelog https://dart.googlesource.com/shelf.git/+/8baca2f Added authors and tool for publishing packages https://dart.googlesource.com/shelf.git/+/9d9d82c Added packages shelf_router and shelf_router_generator ``` Diff: https://dart.googlesource.com/shelf.git/+/fadca320b04689be9ec960013843a0d9ee6c4fc4~..05f42601d22c9bfe490ceda50e812f83b7d1de77/ Change-Id: Icb576d2a6005a036963508c7e32a65752dfb3033 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245903 Commit-Queue: Nate Bosch <nbosch@google.com> Auto-Submit: Nate Bosch <nbosch@google.com> Reviewed-by: Kevin Moore <kevmoo@google.com> Commit-Queue: Kevin Moore <kevmoo@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`. browser_launcher (https://github.com/dart-lang/browser_launcher/compare/5fa0bd6..2712dda): 2712dda 2022-12-13 Anna Gringauze Fix internal CI test failures (#35) dartdoc (https://github.com/dart-lang/dartdoc/compare/eb90a44..1f42216): 1f422163 2022-12-13 Sam Rawlins Bump to 6.1.5 (#3274) intl (https://github.com/dart-lang/intl/compare/234b291..6fb07f2): 6fb07f2 2022-12-14 Copybara-Service Merge pull request #520 from dart-lang:revto18 1f9815c 2022-12-14 Moritz Rev version in preparation for publish of 0.18.0 1d37c42 2022-12-13 Googler Internal change 708b85c 2022-12-13 Copybara-Service Merge pull request #498 from dart-lang:remove_intl_stream 2d9eca9 2022-09-28 moritz sort imports 08a35bd 2022-09-28 moritz Merge branch 'master' into remove_intl_stream 0fc6ab9 2022-09-28 moritz Changes as per review 4680742 2022-09-27 moritz rename to stack f687c72 2022-09-27 moritz changes as per review ef36013 2022-09-26 moritz add reference to benchmark 117c0cf 2022-09-26 moritz separate read and pop 434378a 2022-09-26 moritz move method e98c4aa 2022-09-26 moritz fix typo 9234540 2022-09-26 moritz rename file 024cffc 2022-09-26 moritz make it a tad faster c6f7b6a 2022-09-26 moritz some renaming 443c9e0 2022-09-26 moritz Remove StringIterator 1953002 2022-09-23 Nate Bosch Inline the extension 4dfdc1b 2022-09-22 Nate Bosch Simplify the IntlStream class mime (https://github.com/dart-lang/mime/compare/c0c4c47..273d454): 273d454 2022-12-13 tomk9 Add .dcm to extension map (#74) aacec32 2022-12-12 Kevin Moore Update to latest lints, bump min SDK to 2.18 (#77) 536db4f 2022-12-12 Kevin Moore blast_repo fixes (#79) 2343229 2022-12-12 Kevin Moore Add .msj (and change .js) to text/javascript (#76) mockito (https://github.com/dart-lang/mockito/compare/347d3e4..942dd03): 942dd03 2022-12-12 yanok Override `SmartFake.toString` to be super-verbose 5f97a43 2022-12-09 Sam Rawlins Stop using deprecated analyzer APIs 0660e61 2022-12-06 yanok Generate method overrides even then source lib is not null-safe cf7d851 2022-12-06 yanok Add override for `Object.operator==` in `SmartFake` 6b89e99 2022-12-02 yanok Automated g4 rollback of changelist 492410078. d11d010 2022-12-02 yanok Generate method overrides even then source lib is not null-safe sse (https://github.com/dart-lang/sse/compare/d396145..cfa93b1): cfa93b1 2022-12-14 Elliott Brooks (she/her) Add `package:js` to dependencies (#71) 00335e4 2022-12-13 Elliott Brooks (she/her) Update `package:sse` to `4.1.2`(#70) webdev (https://github.com/dart-lang/webdev/compare/3e2364e..317288a): 317288a 2022-12-14 Derek Xu Remove ChromeProxyService.setExceptionPauseMode() (#1820) bbe7143 2022-12-14 Elliott Brooks (she/her) Migrate `events_test.dart` to null-safety (#1819) 1d1c98f 2022-12-14 Elliott Brooks (she/her) Settings page, Dart Debugger panel, and Flutter Inspector panel match DevTools styles (#1815) a9b8887 2022-12-13 Elliott Brooks (she/her) Update tests that are incompatible with `3.0.0` (#1817) Change-Id: I08e555dc22e5577740fe43e91ff31e4601ac15f0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275781 Commit-Queue: Nate Bosch <nbosch@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
…ctor, browser_launcher, characters, clock, collection, convert, crypto, csslib, dartdoc, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, logging, matcher, mime, package_config, path, pool, pub_semver, source_maps, source_span, sse, stack_trace, stream_channel, term_glyph, test, test_descriptor, test_process, tools, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/7a5e3b0..5ac2ba1): 5ac2ba1 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#238) f77b1dc 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#239) async (https://github.com/dart-lang/async/compare/f454380..0127813): 0127813 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#236) 100445b 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#237) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/53871c5..d5f8837): d5f8837 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#70) a8a55e6 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#71) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/725534a..e591ec4): e591ec4 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#86) 38bf5b8 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#87) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/16e6ad3..28dc03d): 28dc03d 2023-04-04 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#45) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/bc2dc4e..ba4e028): ba4e028 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#41) characters (https://github.com/dart-lang/characters/compare/3281cc7..ba8d557): ba8d557 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#79) 60cae68 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#80) clock (https://github.com/dart-lang/clock/compare/984642e..93d9f56): 93d9f56 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#48) collection (https://github.com/dart-lang/collection/compare/30fd0f8..9db854d): 9db854d 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#278) convert (https://github.com/dart-lang/convert/compare/83886e3..8812e40): 8812e40 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79) d28dc33 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#80) crypto (https://github.com/dart-lang/crypto/compare/9efb888..8a03816): 8a03816 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#143) csslib (https://github.com/dart-lang/csslib/compare/d32bdd4..5836863): 5836863 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#177) dartdoc (https://github.com/dart-lang/dartdoc/compare/9be04e0..1a7952b): 1a7952b1 2023-04-03 dependabot[bot] Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#3382) fixnum (https://github.com/dart-lang/fixnum/compare/f8379d9..92ec336): 92ec336 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#108) f14fd19 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#109) glob (https://github.com/dart-lang/glob/compare/f378dc8..eaa878b): eaa878b 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#73) c0c7e66 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#74) html (https://github.com/dart-lang/html/compare/08643e9..57b747d): 57b747d 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#209) 51c9910 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#210) http (https://github.com/dart-lang/http/compare/74f9d3d..ffb4438): ffb4438 2023-04-04 Brian Quinlan Fix maxRedirects documentation to mention ClientException rather than RedirectException (#907) ad0e1cf 2023-04-03 Bahaa Fathi Yousef Fix some spelling (#885) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/7bd190c..e0b5d35): e0b5d35 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#53) 3bbaf22 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#52) http_parser (https://github.com/dart-lang/http_parser/compare/b3b283b..bbe37dd): bbe37dd 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#70) f0527a8 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#71) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/aea3bea..5da2705): 5da2705 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#94) d6ab373 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#95) logging (https://github.com/dart-lang/logging/compare/abef371..787030a): 787030a 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#133) be6a20e 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#134) matcher (https://github.com/dart-lang/matcher/compare/61f4347..cb6b68c): cb6b68c 2023-04-04 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#216) mime (https://github.com/dart-lang/mime/compare/1a51be0..2d8496d): 2d8496d 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#90) 3b39378 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#91) package_config (https://github.com/dart-lang/package_config/compare/74ac1cb..7e09db1): 7e09db1 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#132) 6dc4072 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#133) path (https://github.com/dart-lang/path/compare/cd37179..23e3319): 23e3319 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#140) pool (https://github.com/dart-lang/pool/compare/338bfb4..650e5d3): 650e5d3 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#66) pub_semver (https://github.com/dart-lang/pub_semver/compare/c0e6ea7..860e3d8): 860e3d8 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#82) 12eca92 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#83) source_maps (https://github.com/dart-lang/source_maps/compare/a112e98..0a4b030): 0a4b030 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#76) e753fea 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#75) source_span (https://github.com/dart-lang/source_span/compare/3951ba5..b739fbf): b739fbf 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#94) c6547c2 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#95) sse (https://github.com/dart-lang/sse/compare/8c3efdc..11e83a0): 11e83a0 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79) stack_trace (https://github.com/dart-lang/stack_trace/compare/6ceb191..9c1b1c5): 9c1b1c5 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#128) 56a09db 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#129) stream_channel (https://github.com/dart-lang/stream_channel/compare/fe0f5e4..74646ea): 74646ea 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#88) term_glyph (https://github.com/dart-lang/term_glyph/compare/d275a8f..f6856e2): f6856e2 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#36) test (https://github.com/dart-lang/test/compare/a01b185..8ea4298): 8ea42987 2023-04-04 Jakub Vrána Make tests compatible with Strict CSP (#1987) 49f7e17a 2023-04-03 dependabot[bot] Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#1982) 1a4f76b2 2023-04-03 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.9 (#1985) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/1d4a967..aa11162): aa11162 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49) 226fe86 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#50) test_process (https://github.com/dart-lang/test_process/compare/f76d0b8..946bc27): 946bc27 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#40) 441f585 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#41) tools (https://github.com/dart-lang/tools/compare/d40ca93..0304fbb): 0304fbb 2023-04-04 Elias Yishak Add catcherror callback for `sendData` (#72) 6d1dedf 2023-04-04 Daco Harkes [cli_config] Pub badges (#71) 561dce2 2023-04-04 Daco Harkes [cli_config] Bump version (#68) d3909a4 2023-04-04 Daco Harkes Fix windows path resolving (#67) 77cf078 2023-04-03 Daco Harkes [cli_config] Fix optionalString validValues (#69) usage (https://github.com/dart-lang/usage/compare/399770f..0698711): 0698711 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#190) 2cdb5e3 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#189) watcher (https://github.com/dart-lang/watcher/compare/5968409..00aa79b): 00aa79b 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140) 598038f 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#141) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/e2fe7f6..40eb236): 40eb236 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#260) 1823444 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#261) webdev (https://github.com/dart-lang/webdev/compare/b139649..e887316): e887316c 2023-04-03 Elliott Brooks Prepare DWDS for version `19.0.0` release (#2068) 704d5086 2023-04-03 Elliott Brooks Fix typo (#2069) 2e6e1b63 2023-04-03 Anna Gringauze Fix getObject failure on record class. (#2063) yaml (https://github.com/dart-lang/yaml/compare/0f80b12..56dfaf4): 56dfaf4 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140) d925d7e 2023-04-03 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.0 (#141) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/fbc5cb3..386fd33): 386fd33 2023-04-03 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49) Change-Id: I986c83f657631813a32e360fbb90f42f7d43440a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293280 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was originally filed by v.e.egor...@gmail.com
http://code.google.com/p/dart/source/browse/trunk/dart/compiler/lib/implementation/bool.js#19
Boolean(new Boolean(true)) === Boolean(new Boolean(false)) === true.
It is not clear whether this code is really needed.
Pointed out by Andrea Giammarchi.
The text was updated successfully, but these errors were encountered: