Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various native functions are not hidden from mirrors. #15274

Closed
rmacnak-google opened this issue Nov 22, 2013 · 4 comments
Closed

Various native functions are not hidden from mirrors. #15274

rmacnak-google opened this issue Nov 22, 2013 · 4 comments
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-mirrors

Comments

@rmacnak-google
Copy link
Contributor

mirrors/invoke_natives_test: Crash
@rmacnak-google
Copy link
Contributor Author

r35289

Added Fixed label.

@ghost
Copy link

ghost commented Sep 29, 2014

There is still a blacklist with cases where the VM throws uncatchable API errors:

  // These either cause the VM to segfault or throw uncatchable API errors.
  // TODO(15274): Fix them and remove from blacklist.
  'dart.io._IOService.dispatch',
  new RegExp(r'._RandomAccessFile.'),
  'dart.io._StdIOUtils._socketType',
  'dart.io._StdIOUtils._getStdioOutputStream',
  'dart.io._Filter.newZLibInflateFilter',
  'dart.io._Filter.newZLibDeflateFilter',
  'dart.io._FileSystemWatcher._listenOnSocket',
  'dart.io.SystemEncoding.decode',
  'dart.io.SystemEncoding.encode',
  'dart.core.StringBuffer.toString', /// emptyarray: ok

@ghost
Copy link

ghost commented Sep 29, 2014

Added Triaged label.

@rmacnak-google
Copy link
Contributor Author

r43053. Remainder is a bug in io not mirrors.

Added Fixed label.

@rmacnak-google rmacnak-google added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-mirrors labels Jan 28, 2015
@rmacnak-google rmacnak-google self-assigned this Jan 28, 2015
dart-bot pushed a commit that referenced this issue Jul 25, 2019
@rmacnak-google
Add various missing argument checks to dart:io natives.
ba72890 
Change type checks in embedding API functions to return UnhandledExceptionErrors instead of APIErrors so they are catchable by Dart.

Fixes invocation_fuzz_test.

Bug: #15274
Bug: #23869
Change-Id: Ia6103e7ffceda897e475c1a3ba534c2f4b910475
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110020
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
dart-bot pushed a commit that referenced this issue Jul 25, 2019
@rmacnak-google
Revert "Add various missing argument checks to dart:io natives."
938d3be 
This reverts commit ba72890.

Reason for revert: Crash in bytecode modes

Original change's description:
> Add various missing argument checks to dart:io natives.
> 
> Change type checks in embedding API functions to return UnhandledExceptionErrors instead of APIErrors so they are catchable by Dart.
> 
> Fixes invocation_fuzz_test.
> 
> Bug: #15274
> Bug: #23869
> Change-Id: Ia6103e7ffceda897e475c1a3ba534c2f4b910475
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110020
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=sortie@google.com,rmacnak@google.com,asiva@google.com

Change-Id: Ib52ec03caf4b177cd91bb1d366df51588bf23177
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #15274, #23869
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110580
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
dart-bot pushed a commit that referenced this issue Aug 2, 2019
@rmacnak-google
Add various missing argument checks to dart:io natives.
d08c203 
Avoid reflective access to mirrors creating invalid reflectees.

Change type checks in embedding API functions to return UnhandledExceptionErrors instead of APIErrors so they are catchable by Dart.

Fixes invocation_fuzz_test.

Bug: #15274
Bug: #23869
Bug: #37680
Change-Id: Ife3e3cb894c59620b0318e4e08947a3d1d45bab9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110620
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-mirrors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @rmacnak-google