lib_2/mirrors/invocation_fuzz_test/emptyarray fails on Mac Product #37680
Assignees
Labels
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
crash
Process exits with SIGSEGV, SIGABRT, etc. An unhandled exception is not a crash.
gardening
library-ffi
Comments
sjindel-google
added
area-vm
|
@sjindel-google Did you investigate why the VM segfaults? |
mkustermann
added
crash
|
I didn't recognize the segfault due to the absence of a stack trace -- I thought it was a normal error. I'll take a look. |
|
(the flakiness dashboard as well as the failure mention it's a Crash) |
|
Likely fixed by https://dart-review.googlesource.com/c/sdk/+/110620 |
dart-bot
pushed a commit
that referenced
this issue
Aug 2, 2019
Avoid reflective access to mirrors creating invalid reflectees. Change type checks in embedding API functions to return UnhandledExceptionErrors instead of APIErrors so they are catchable by Dart. Fixes invocation_fuzz_test. Bug: #15274 Bug: #23869 Bug: #37680 Change-Id: Ife3e3cb894c59620b0318e4e08947a3d1d45bab9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110620 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
|
BigQuery and the flakiness dashboard form that the test is still crashing flakily. |
|
This appears to be the same cause as #37780, the original fix was not complete. I've uploaded https://dart-review.googlesource.com/c/sdk/+/114861 to address it. |
dart-bot
pushed a commit
that referenced
this issue
Aug 29, 2019
…ned. Issue #37680 NativeFunction was not handled despite being concrete. We can just make it (and Void) abstract because they cannot appear directly as the type of native field, only as a type argument. Change-Id: I92c276b7c1c4c98624bf527ccff98f5fd077bf2c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114861 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8906421057139188768/+/steps/test_results/0/logs/unapproved_failing_tests__logs_/0
The failure appears to be caused by
fe2f8265or59aa4cd6.The text was updated successfully, but these errors were encountered: