Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor icon defaults to New File, puts editor in inconsistent space #237

Closed
lukechurch opened this issue Oct 26, 2011 · 2 comments
Closed
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@lukechurch
Copy link
Contributor

Upon running the editor the new icon is 'New File', not 'New Application'. Clicking this places the editor in an inconsistent state, with a blank library view etc. Other strange behaviors occurs subsequently.

Issue is seriously derailing users during studies.

@jwren
Copy link
Member

jwren commented Oct 26, 2011

Set owner to @jwren.
Added Accepted label.

@jwren
Copy link
Member

jwren commented Oct 26, 2011

Fixed with http://codereview.chromium.org/8390054/


Added Done label.

@lukechurch lukechurch added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Oct 26, 2011
pq added a commit that referenced this issue May 18, 2016
Adds:

* Fix to `public_member_api_docs` to check for documented getters when checking setters (#237).
* New `iterable_contains_unrelated_type` lint to detect when `Iterable.contains` is invoked with an object of an unrelated type.
* New `comment_references` lint to ensure identifiers referenced in docs are in scope (#240).

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1993863002 .
copybara-service bot pushed a commit that referenced this issue Mar 15, 2023
…dev, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0):
  7a5e3b0  2023-03-14  Devon Carew  update readme; add contributing doc (#237)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a):
  725534a  2023-03-14  Kevin Moore  Spelling fixes, latest lints, move to minilibs (drop parts) (#85)

csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4):
  d32bdd4  2023-03-14  Devon Carew  refactor the package example (#170)

dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4):
  7fde7a4d  2023-03-13  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)

http (https://github.com/dart-lang/http/compare/805a147..74f9d3d):
  74f9d3d  2023-03-09  Brian Quinlan  Add conformances test that verify that the Client works in Isolates (#889)
  ee03604  2023-03-09  Brian Quinlan  Add a flag to allow the default Client to be tree shaken away. (#868)
  2039fb3  2023-03-09  Brian Quinlan  Fix a reference count race with forwarded delegates. (#888)

shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4):
  9a792b4  2023-03-13  Kevin Moore  Update format for latest v3 SDK (#340)
  c8094b7  2023-03-13  Kevin Moore  Update no-response.yml - once a day (#339)

webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0):
  a15fde0  2023-03-15  Anna Gringauze  fix matching record types (#2032)
  05031da  2023-03-14  Anna Gringauze  Update build_daemon constraint and log errors (#2029)
  49013b8  2023-03-09  Elliott Brooks (she/her)  [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
  c8d4439  2023-03-09  Elliott Brooks (she/her)  Support `Set` inspection in DWDS (#2024)
  442639d  2023-03-08  Elliott Brooks (she/her)  Handle unexpected extension debugger disconnection events without crashing app (#2021)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3):
  fbc5cb3  2023-03-09  Kevin Moore  Require Dart 2.19, update to latest lints
  c9e82f0  2023-03-09  Mohamed Ishad  Fix YamlEditor.update method leaving trailing spaces at eol (#42)

Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 15, 2023
…elf, webdev, yaml_edit"

This reverts commit aab39d3.

Reason for revert: Failing some internal builds with the following error
http_client_conformance_tests: #wrong_required_libs #wrong_conditional_srcs
  "required_libs" is currently [] but the code imports ["isolate"].

Original change's description:
> [deps] rev args, benchmark_harness, csslib, dartdoc, http, shelf, webdev, yaml_edit
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0):
>   7a5e3b0  2023-03-14  Devon Carew  update readme; add contributing doc (#237)
>
> benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a):
>   725534a  2023-03-14  Kevin Moore  Spelling fixes, latest lints, move to minilibs (drop parts) (#85)
>
> csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4):
>   d32bdd4  2023-03-14  Devon Carew  refactor the package example (#170)
>
> dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4):
>   7fde7a4d  2023-03-13  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)
>
> http (https://github.com/dart-lang/http/compare/805a147..74f9d3d):
>   74f9d3d  2023-03-09  Brian Quinlan  Add conformances test that verify that the Client works in Isolates (#889)
>   ee03604  2023-03-09  Brian Quinlan  Add a flag to allow the default Client to be tree shaken away. (#868)
>   2039fb3  2023-03-09  Brian Quinlan  Fix a reference count race with forwarded delegates. (#888)
>
> shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4):
>   9a792b4  2023-03-13  Kevin Moore  Update format for latest v3 SDK (#340)
>   c8094b7  2023-03-13  Kevin Moore  Update no-response.yml - once a day (#339)
>
> webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0):
>   a15fde0  2023-03-15  Anna Gringauze  fix matching record types (#2032)
>   05031da  2023-03-14  Anna Gringauze  Update build_daemon constraint and log errors (#2029)
>   49013b8  2023-03-09  Elliott Brooks (she/her)  [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
>   c8d4439  2023-03-09  Elliott Brooks (she/her)  Support `Set` inspection in DWDS (#2024)
>   442639d  2023-03-08  Elliott Brooks (she/her)  Handle unexpected extension debugger disconnection events without crashing app (#2021)
>
> yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3):
>   fbc5cb3  2023-03-09  Kevin Moore  Require Dart 2.19, update to latest lints
>   c9e82f0  2023-03-09  Mohamed Ishad  Fix YamlEditor.update method leaving trailing spaces at eol (#42)
>
> Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Auto-Submit: Devon Carew <devoncarew@google.com>

Change-Id: I07b1e6041babc92df359da89eb18c1daf2634d88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289024
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
copybara-service bot pushed a commit that referenced this issue Mar 20, 2023
… shelf, tools, vector_math, webdev, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0):
  7a5e3b0  2023-03-14  Devon Carew  update readme; add contributing doc (#237)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a):
  725534a  2023-03-14  Kevin Moore  Spelling fixes, latest lints, move to minilibs (drop parts) (#85)

clock (https://github.com/dart-lang/clock/compare/5abb481..984642e):
  984642e  2023-03-15  Kevin Moore  Require Dart 2.19, use and fix recommended lints (#46)

csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4):
  d32bdd4  2023-03-14  Devon Carew  refactor the package example (#170)

dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4):
  7fde7a4d  2023-03-13  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)

protobuf (https://github.com/dart-lang/protobuf/compare/75bc380..b90a4c4):
  b90a4c4  2023-03-16  Mahdi K. Fard  Sort message constructors first. (#807)
  00fd975  2023-03-15  Kevin Moore  Fix formatting with latest SDK (#808)
  a67bbb3  2023-03-15  dependabot[bot]  Bump actions/cache from 3.2.4 to 3.2.6 (#804)

shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4):
  9a792b4  2023-03-13  Kevin Moore  Update format for latest v3 SDK (#340)
  c8094b7  2023-03-13  Kevin Moore  Update no-response.yml - once a day (#339)

tools (https://github.com/dart-lang/tools/compare/e5353aa..8d18d01):
  8d18d01  2023-03-15  Elias Yishak  Implement fake ga client (#37)

vector_math (https://github.com/google/vector_math.dart/compare/1e4d000..7dec984):
  7dec984  2023-03-16  eoineoineoin  Add operator== to Quaternion (#288)

webdev (https://github.com/dart-lang/webdev/compare/cfe9753..c2c8b17):
  c2c8b17  2023-03-16  Elliott Brooks (she/her)  Prepare Webdev version `3.0.2` for release (#2037)
  d124fa5  2023-03-16  Elliott Brooks (she/her)  Prepare extension for release (#2036)
  aef715d  2023-03-15  Elliott Brooks (she/her)  Prepare DWDS 18.0.1 for release (#2035)
  a15fde0  2023-03-15  Anna Gringauze  fix matching record types (#2032)
  05031da  2023-03-14  Anna Gringauze  Update build_daemon constraint and log errors (#2029)
  49013b8  2023-03-09  Elliott Brooks (she/her)  [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
  c8d4439  2023-03-09  Elliott Brooks (she/her)  Support `Set` inspection in DWDS (#2024)
  442639d  2023-03-08  Elliott Brooks (she/her)  Handle unexpected extension debugger disconnection events without crashing app (#2021)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3):
  fbc5cb3  2023-03-09  Kevin Moore  Require Dart 2.19, update to latest lints
  c9e82f0  2023-03-09  Mohamed Ishad  Fix YamlEditor.update method leaving trailing spaces at eol (#42)

Change-Id: Icf15fc0ffd3ee36e0380751d18fd491de071040e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289881
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Apr 4, 2023
…ctor, browser_launcher, characters, clock, collection, convert, crypto, csslib, dartdoc, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, logging, matcher, mime, package_config, path, pool, pub_semver, source_maps, source_span, sse, stack_trace, stream_channel, term_glyph, test, test_descriptor, test_process, tools, usage, watcher, web_socket_channel, webdev, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/7a5e3b0..5ac2ba1):
  5ac2ba1  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#238)
  f77b1dc  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#239)

async (https://github.com/dart-lang/async/compare/f454380..0127813):
  0127813  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#236)
  100445b  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#237)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/53871c5..d5f8837):
  d5f8837  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#70)
  a8a55e6  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#71)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/725534a..e591ec4):
  e591ec4  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#86)
  38bf5b8  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#87)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/16e6ad3..28dc03d):
  28dc03d  2023-04-04  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#45)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/bc2dc4e..ba4e028):
  ba4e028  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#41)

characters (https://github.com/dart-lang/characters/compare/3281cc7..ba8d557):
  ba8d557  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#79)
  60cae68  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#80)

clock (https://github.com/dart-lang/clock/compare/984642e..93d9f56):
  93d9f56  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#48)

collection (https://github.com/dart-lang/collection/compare/30fd0f8..9db854d):
  9db854d  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#278)

convert (https://github.com/dart-lang/convert/compare/83886e3..8812e40):
  8812e40  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79)
  d28dc33  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#80)

crypto (https://github.com/dart-lang/crypto/compare/9efb888..8a03816):
  8a03816  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#143)

csslib (https://github.com/dart-lang/csslib/compare/d32bdd4..5836863):
  5836863  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#177)

dartdoc (https://github.com/dart-lang/dartdoc/compare/9be04e0..1a7952b):
  1a7952b1  2023-04-03  dependabot[bot]  Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#3382)

fixnum (https://github.com/dart-lang/fixnum/compare/f8379d9..92ec336):
  92ec336  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#108)
  f14fd19  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#109)

glob (https://github.com/dart-lang/glob/compare/f378dc8..eaa878b):
  eaa878b  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#73)
  c0c7e66  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#74)

html (https://github.com/dart-lang/html/compare/08643e9..57b747d):
  57b747d  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#209)
  51c9910  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#210)

http (https://github.com/dart-lang/http/compare/74f9d3d..ffb4438):
  ffb4438  2023-04-04  Brian Quinlan  Fix maxRedirects documentation to mention ClientException rather than RedirectException (#907)
  ad0e1cf  2023-04-03  Bahaa Fathi Yousef  Fix some spelling (#885)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/7bd190c..e0b5d35):
  e0b5d35  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#53)
  3bbaf22  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#52)

http_parser (https://github.com/dart-lang/http_parser/compare/b3b283b..bbe37dd):
  bbe37dd  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#70)
  f0527a8  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#71)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/aea3bea..5da2705):
  5da2705  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#94)
  d6ab373  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#95)

logging (https://github.com/dart-lang/logging/compare/abef371..787030a):
  787030a  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#133)
  be6a20e  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#134)

matcher (https://github.com/dart-lang/matcher/compare/61f4347..cb6b68c):
  cb6b68c  2023-04-04  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#216)

mime (https://github.com/dart-lang/mime/compare/1a51be0..2d8496d):
  2d8496d  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#90)
  3b39378  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#91)

package_config (https://github.com/dart-lang/package_config/compare/74ac1cb..7e09db1):
  7e09db1  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#132)
  6dc4072  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#133)

path (https://github.com/dart-lang/path/compare/cd37179..23e3319):
  23e3319  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#140)

pool (https://github.com/dart-lang/pool/compare/338bfb4..650e5d3):
  650e5d3  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#66)

pub_semver (https://github.com/dart-lang/pub_semver/compare/c0e6ea7..860e3d8):
  860e3d8  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#82)
  12eca92  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#83)

source_maps (https://github.com/dart-lang/source_maps/compare/a112e98..0a4b030):
  0a4b030  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#76)
  e753fea  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#75)

source_span (https://github.com/dart-lang/source_span/compare/3951ba5..b739fbf):
  b739fbf  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#94)
  c6547c2  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#95)

sse (https://github.com/dart-lang/sse/compare/8c3efdc..11e83a0):
  11e83a0  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#79)

stack_trace (https://github.com/dart-lang/stack_trace/compare/6ceb191..9c1b1c5):
  9c1b1c5  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#128)
  56a09db  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#129)

stream_channel (https://github.com/dart-lang/stream_channel/compare/fe0f5e4..74646ea):
  74646ea  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#88)

term_glyph (https://github.com/dart-lang/term_glyph/compare/d275a8f..f6856e2):
  f6856e2  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#36)

test (https://github.com/dart-lang/test/compare/a01b185..8ea4298):
  8ea42987  2023-04-04  Jakub Vrána  Make tests compatible with Strict CSP (#1987)
  49f7e17a  2023-04-03  dependabot[bot]  Bump ossf/scorecard-action from 2.1.2 to 2.1.3 (#1982)
  1a4f76b2  2023-04-03  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.9 (#1985)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/1d4a967..aa11162):
  aa11162  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49)
  226fe86  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#50)

test_process (https://github.com/dart-lang/test_process/compare/f76d0b8..946bc27):
  946bc27  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#40)
  441f585  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#41)

tools (https://github.com/dart-lang/tools/compare/d40ca93..0304fbb):
  0304fbb  2023-04-04  Elias Yishak  Add catcherror callback for `sendData` (#72)
  6d1dedf  2023-04-04  Daco Harkes  [cli_config] Pub badges (#71)
  561dce2  2023-04-04  Daco Harkes  [cli_config] Bump version (#68)
  d3909a4  2023-04-04  Daco Harkes  Fix windows path resolving (#67)
  77cf078  2023-04-03  Daco Harkes  [cli_config] Fix optionalString validValues (#69)

usage (https://github.com/dart-lang/usage/compare/399770f..0698711):
  0698711  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#190)
  2cdb5e3  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#189)

watcher (https://github.com/dart-lang/watcher/compare/5968409..00aa79b):
  00aa79b  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140)
  598038f  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#141)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/e2fe7f6..40eb236):
  40eb236  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#260)
  1823444  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#261)

webdev (https://github.com/dart-lang/webdev/compare/b139649..e887316):
  e887316c  2023-04-03  Elliott Brooks  Prepare DWDS for version `19.0.0` release (#2068)
  704d5086  2023-04-03  Elliott Brooks  Fix typo (#2069)
  2e6e1b63  2023-04-03  Anna Gringauze  Fix getObject failure on record class. (#2063)

yaml (https://github.com/dart-lang/yaml/compare/0f80b12..56dfaf4):
  56dfaf4  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#140)
  d925d7e  2023-04-03  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.0 (#141)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/fbc5cb3..386fd33):
  386fd33  2023-04-03  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#49)

Change-Id: I986c83f657631813a32e360fbb90f42f7d43440a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293280
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 8, 2024
matcher (https://github.com/dart-lang/matcher/compare/fcbd361..d9cf4f6):
  d9cf4f6  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#240)
  7ea9047  2023-12-13  Kevin Moore  Update test_api dependency, bump & fix lints, prepare release (#237)
  050fdda  2023-12-13  Kevin Moore  blast_repo fixes (#238)

mockito (https://github.com/dart-lang/mockito/compare/57a7c82..e15e000):
  e15e000  2023-12-14  Sam Rawlins  Bump mockito to 5.4.4
  a2a6566  2023-12-14  Copybara-Service  Merge pull request #726 from provokateurin:chore/deps/test_api-0.7
  bda332c  2023-12-14  jld3103  chore(deps): Allow test_api 0.7
  9bd6fb0  2023-12-12  Paul Berry  Remove mockito pre-null-safety tests.

test (https://github.com/dart-lang/test/compare/43ff5bf..846d73e):
  846d73ee  2024-01-01  dependabot[bot]  Bump actions/upload-artifact from 3.1.3 to 4.0.0 (#2165)
  0ab56790  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#2167)
  3b960c3e  2024-01-01  dependabot[bot]  Bump github/codeql-action from 2.22.8 to 3.22.12 (#2166)
  30543cae  2023-12-19  Nate Bosch  Add more logging around iframe startup (#2160)
  e56a5e22  2023-12-13  Jacob MacDonald  small cleanup in catch (#2159)
  15b39372  2023-12-13  Jacob MacDonald  handle missing package config files (#2158)
  9667cca8  2023-12-13  Jacob MacDonald  release test_api 7.0.0, test_core 6.0.0, and test 1.25.0 (#2156)
  b3fb1486  2023-12-13  Nate Bosch  Remove support for Internet Explorer (#2114)
  48a2bc3d  2023-12-13  Derek Xu  Update the package:vm_service constraint to allow version 14.x (#2157)

Change-Id: I386444652c47cd14a61665599d86dc3a7669a2fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345341
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

3 participants