-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to compile: ObservableList<T> extends ListFactory<T> #888
Comments
[user feedback] to General minfrog compiles my project on Ubuntu successfully. Dart Editor 2380 on Windows 32 or 64 acts as if it's building my Dart Editor 2428 on Ubuntu 32 bit also will not write out a .js file Am I missing something in the configuration? |
[user feedback] to General I have an ObservableList<T> class that extends ListFactory minfrog compiles it with no problem but dartc appears to be having Added OpSys-Windows label. |
This comment was originally written by mmendez@google.com The ListFactory that dartc currently has in its implementation library is not parameterized hence the error about the wrong number of type arguments. This error also prevents codegeneration. The following review http://codereview.chromium.org/8948001/ is updating ListFactory as part of the spec changes included in v0.6 which included parameterizing ListFactory. |
This comment was originally written by mmendez@google.com Set owner to zundel@google.com. |
This comment was originally written by zundel@google.com ListFactory is now parameterized Added Fixed label. |
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) matcher (https://github.com/dart-lang/matcher/compare/c1a0704..985e4ef): 985e4ef 2023-03-10 Sigurd Meldgaard Improve mismatch description of `contains` (#206) 5bc765d 2023-03-09 Nate Bosch Copy expect and async matchers from test package (#210) shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) test (https://github.com/dart-lang/test/compare/3ba78f1..0e5c028): 0e5c028d 2023-03-10 Nate Bosch Only use environment variable for chrome (#1970) 0b08d704 2023-03-08 Nate Bosch Add a hooks_testing library (#1952) aacee2c7 2023-03-08 Nate Bosch Retry filesystem deletes (#1965) webdev (https://github.com/dart-lang/webdev/compare/cfe9753..49013b8): 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) Change-Id: Idc785347448e6a56e26d9d46b3666440d59c22de Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288801 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
…edit" This reverts commit fcb8f80. Reason for revert: google3 roll failure Original change's description: > [deps] rev dartdoc, http, matcher, shelf, test, webdev, yaml_edit > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): > 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) > > http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): > 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) > ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) > 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) > > matcher (https://github.com/dart-lang/matcher/compare/c1a0704..985e4ef): > 985e4ef 2023-03-10 Sigurd Meldgaard Improve mismatch description of `contains` (#206) > 5bc765d 2023-03-09 Nate Bosch Copy expect and async matchers from test package (#210) > > shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): > 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) > c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) > > test (https://github.com/dart-lang/test/compare/3ba78f1..0e5c028): > 0e5c028d 2023-03-10 Nate Bosch Only use environment variable for chrome (#1970) > 0b08d704 2023-03-08 Nate Bosch Add a hooks_testing library (#1952) > aacee2c7 2023-03-08 Nate Bosch Retry filesystem deletes (#1965) > > webdev (https://github.com/dart-lang/webdev/compare/cfe9753..49013b8): > 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) > c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) > 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) > > yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): > fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints > c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) > > Change-Id: Idc785347448e6a56e26d9d46b3666440d59c22de > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288801 > Auto-Submit: Devon Carew <devoncarew@google.com> > Reviewed-by: Konstantin Shcheglov <scheglov@google.com> > Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Change-Id: If7dd2027f4b6ead777eaf1b3cf7561d4dced4095 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288802 Auto-Submit: Devon Carew <devoncarew@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
…dev, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0): 7a5e3b0 2023-03-14 Devon Carew update readme; add contributing doc (#237) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a): 725534a 2023-03-14 Kevin Moore Spelling fixes, latest lints, move to minilibs (drop parts) (#85) csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4): d32bdd4 2023-03-14 Devon Carew refactor the package example (#170) dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0): a15fde0 2023-03-15 Anna Gringauze fix matching record types (#2032) 05031da 2023-03-14 Anna Gringauze Update build_daemon constraint and log errors (#2029) 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
…elf, webdev, yaml_edit" This reverts commit aab39d3. Reason for revert: Failing some internal builds with the following error http_client_conformance_tests: #wrong_required_libs #wrong_conditional_srcs "required_libs" is currently [] but the code imports ["isolate"]. Original change's description: > [deps] rev args, benchmark_harness, csslib, dartdoc, http, shelf, webdev, yaml_edit > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0): > 7a5e3b0 2023-03-14 Devon Carew update readme; add contributing doc (#237) > > benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a): > 725534a 2023-03-14 Kevin Moore Spelling fixes, latest lints, move to minilibs (drop parts) (#85) > > csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4): > d32bdd4 2023-03-14 Devon Carew refactor the package example (#170) > > dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): > 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) > > http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): > 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) > ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) > 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) > > shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): > 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) > c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) > > webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0): > a15fde0 2023-03-15 Anna Gringauze fix matching record types (#2032) > 05031da 2023-03-14 Anna Gringauze Update build_daemon constraint and log errors (#2029) > 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) > c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) > 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) > > yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): > fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints > c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) > > Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023 > Reviewed-by: Konstantin Shcheglov <scheglov@google.com> > Commit-Queue: Konstantin Shcheglov <scheglov@google.com> > Auto-Submit: Devon Carew <devoncarew@google.com> Change-Id: I07b1e6041babc92df359da89eb18c1daf2634d88 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289024 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Siva Annamalai <asiva@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) Change-Id: I56faf5cf41ad16f6a365db66265b02e66adbc59f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289502 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Devon Carew <devoncarew@google.com> Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`. lints (https://github.com/dart-lang/lints/compare/2cf8403..5c60f48): 5c60f48 2023-10-30 Michael Goderbauer Update README.md to use new syntax for adding dev dependencies (#167) mockito (https://github.com/dart-lang/mockito/compare/4edf86f..b7d752e): b7d752e 2023-10-26 Ilya Yanok Use Dart SDK 3.1.0 for format check ca537db 2023-10-26 Ilya Yanok Remove unneeded deprecation warning disable comment 1a0d0e7 2023-10-26 Ilya Yanok Remove deprecated `returnNullOnMissingStub` and `OnMissingStub.returnNull` native (https://github.com/dart-lang/native/compare/757f503..279094d): 279094d 2023-10-30 Pierrick Bouvier [native_toolchain_c] Support MSVC arm64 toolchain (#167) 9629a55 2023-10-27 Parker Lougheed Allow modification of a BuildOutput's raw dependencies (#169) 762b4da 2023-10-27 Ryan Macnak [native_assets_cli] Add Android RISCV64 target. (#166) 18bff8c 2023-10-25 Ryan Macnak [native_toolchain_c] Setup Linux X64 toolchain for non-X64 hosts. (#164) d79a7cd 2023-10-25 Ryan Macnak [native_toolchain_c] Setup Linux RISCV64 toolchain. (#163) ce26f75 2023-10-25 Parker Lougheed Update all lints and dart_flutter_team_lints dependencies (#161) protobuf (https://github.com/dart-lang/protobuf/compare/3528fad..3f567b2): 3f567b2 2023-10-27 Ömer Sinan Ağacan Remove the dynamic call in `CodedBufferWriter` (#895) 42436cd 2023-10-26 Ömer Sinan Ağacan Keep a `ByteData` around in `CodedBufferReader` to avoid repeated `ByteData` allocs (#890) 9a73936 2023-10-26 Ömer Sinan Ağacan Avoid adding empty splices in `CodedBufferWriter` (#886) 23dffde 2023-10-26 Ömer Sinan Ağacan Update a bug link in a comment (#892) 19903f0 2023-10-26 Ömer Sinan Ağacan Make `CodedBufferWriter.writeRawByte` argument type more accurate (#891) 2ce3e14 2023-10-26 Ömer Sinan Ağacan Update `FieldInfo._ensureRepeatedField` return type (#893) e146515 2023-10-25 Ömer Sinan Ağacan Avoid redundant ByteData allocation when decoding sfixed64 (#889) 1b1d549 2023-10-25 Ömer Sinan Ağacan Avoid allocating temporary views in when decoding strings in `CodedBufferReader` (#888) tools (https://github.com/dart-lang/tools/compare/da6bb18..e828d45): e828d45 2023-10-27 Elias Yishak Create tests for each event constructor (#186) webdev (https://github.com/dart-lang/webdev/compare/25f17cd..50534a1): 50534a12 2023-10-30 Elliott Brooks Cider passes an app ID instead of a workspace name to connect to the Dart Debug Extension (#2272) b3d6ef14 2023-10-27 Elliott Brooks Expose a keyboard shortcut to copy the Dart app ID (#2271) c26b4e5f 2023-10-27 Elliott Brooks Reset Webdev to 3.3.0-wip after release (#2269) 982b955b 2023-10-26 Elliott Brooks Prepare webdev for 3.2.0 (#2268) 62361fbf 2023-10-26 Elliott Brooks Reset DWDS after release (#2267) 50b8ae86 2023-10-26 Elliott Brooks Prepare DWDS for release to version 22.1.0 (#2266) Change-Id: Ia02db3bc66bac55b637ed5e173fe5c5d50bcca52 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332748 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
[user feedback]
minfrog compiles this fine, but dartc is giving "ListFactory: wrong numer of type arguements"
prujohn@gmail.com
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 2517
OS: Linux
////////////////////////////////////////////////////////////////////////////////////
.reduce(TreeShaker.java:174)
at com.google.dart.compiler.backend.js.JavascriptBackend.packageApp(JavascriptBackend.java:187)
at com.google.dart.compiler.DartCompiler$Compiler.packageApp(DartCompiler.java:791)
at com.google.dart.compiler.DartCompiler$Compiler.compile(DartCompiler.java:178)
at com.google.dart.compiler.DartCompiler$Compiler.access$3(DartCompiler.java:166)
at com.google.dart.compiler.DartCompiler.compileLib(DartCompiler.java:1142)
at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.secureCompileLib(DartCompilerUtilities.java:796)
at com.google.dart.tools.core.internal.builder.DartBuilder.buildLibrary(DartBuilder.java:399)
at com.google.dart.tools.core.internal.builder.DartBuilder.buildAllApplications(DartBuilder.java:303)
at com.google.dart.tools.core.internal.builder.DartBuilder.build(DartBuilder.java:272)
at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:728)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:199)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:239)
at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:292)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:295)
at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:351)
at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:374)
at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:143)
at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:241)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
The text was updated successfully, but these errors were encountered: