Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standalone/io/http_proxy_advanced_test fails #24074

Closed
whesse opened this issue Aug 13, 2015 · 4 comments
Closed

standalone/io/http_proxy_advanced_test fails #24074

whesse opened this issue Aug 13, 2015 · 4 comments
Assignees
@whesse
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io P2 A bug or feature request we're likely to work on

Comments

@whesse
Copy link
Contributor

whesse commented Aug 13, 2015

There are commented-out subtests of standalone/io/http_proxy_test in the BoringSSL implementation branch. These should be put in separate tests, issues filed, and marked in the status file.
@whesse whesse self-assigned this Aug 13, 2015
@whesse whesse added this to the 1.13 milestone Aug 13, 2015
@kevmoo kevmoo added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Aug 14, 2015
@whesse
Copy link
Contributor Author

whesse commented Aug 21, 2015

Do this by making them multitests. All passing tests in one multitest, and failing ones in separate ones.

@whesse
Copy link
Contributor Author

whesse commented Oct 5, 2015

Making these tests multitests makes them fail, because the necessary resources aren't copied over with them (the certificates and keys from the certificates/ directory). Will copy failing ones to a separate test file.

@whesse whesse removed this from the 1.13 milestone Oct 5, 2015
@whesse
Copy link
Contributor Author

whesse commented Oct 5, 2015

The tests have been moved to http_proxy_advanced_test. The tests that fail are
testProxyIPV6
testProxyFromEnvironment
and
testProxyAuthenticate

@whesse whesse changed the title Make multiple tests out of standalone/io/http_proxy_test standalone/io/http_proxy_advanced_test fails Oct 5, 2015
whesse added a commit that referenced this issue Oct 6, 2015
@whesse
Add full BoringSSL error information to Dart exceptions it throws.
da57412 
Fix error in http_proxy_advanced_test.

BUG=#24183
BUG=#24068
BUG=#24074
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1386023003 .
@whesse
Copy link
Contributor Author

whesse commented Oct 6, 2015

The tests have been fixed, but they are still split into two test files, for ease of future diagnosis and testing. Fixed in https://codereview.chromium.org/1386023003/

@whesse whesse closed this as completed Oct 6, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed Priority-Medium labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @whesse