Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoringSSL - Throw exceptions that include the full SSL error stack, with all messages #24183

Closed
whesse opened this issue Aug 24, 2015 · 1 comment
Closed

BoringSSL - Throw exceptions that include the full SSL error stack, with all messages #24183

whesse opened this issue Aug 24, 2015 · 1 comment
Assignees
@whesse
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io P2 A bug or feature request we're likely to work on
Milestone
1.13

Comments

@whesse
Copy link
Contributor

whesse commented Aug 24, 2015

BoringSSL puts errors it encounters on a stack of errors, so when we encounter an unexpected error, we should get all the BoringSSL errors off the stack, and put them into an exception message, in a Dart exception, and throw it.
@whesse whesse added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io labels Aug 24, 2015
@whesse whesse self-assigned this Aug 24, 2015
@whesse whesse added this to the 1.13 milestone Aug 24, 2015
whesse added a commit that referenced this issue Oct 6, 2015
@whesse
Add full BoringSSL error information to Dart exceptions it throws.
da57412 
Fix error in http_proxy_advanced_test.

BUG=#24183
BUG=#24068
BUG=#24074
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1386023003 .
@whesse
Copy link
Contributor Author

whesse commented Oct 6, 2015

Fixed by https://codereview.chromium.org/1386023003/

@whesse whesse closed this as completed Oct 6, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed Priority-Medium labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
2 participants
@kevmoo @whesse