Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose (or at least mark as deprecated) implementation APIs from dart:html and the like #24602

Closed
kevmoo opened this issue Oct 15, 2015 · 9 comments
Closed

Don't expose (or at least mark as deprecated) implementation APIs from dart:html and the like #24602

kevmoo opened this issue Oct 15, 2015 · 9 comments
Assignees
@terrylucas
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Milestone
1.13

Comments

@kevmoo
Copy link
Member

kevmoo commented Oct 15, 2015

See https://api.dartlang.org/1.13.0-dev.7.0/dart-html/wrap_jso.html
@kevmoo kevmoo added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. Area-Dartium labels Oct 15, 2015
@kevmoo kevmoo added this to the 1.13 milestone Oct 15, 2015
@alan-knight
Copy link
Contributor

https://codereview.chromium.org/1409743003/

alan-knight added a commit that referenced this issue Oct 19, 2015
@alan-knight
Hide internal methods like wrap_jso from the dart:html public interface
a936261 
Issue #24602

R=terry@google.com

Review URL: https://codereview.chromium.org/1409743003 .
alan-knight added a commit that referenced this issue Oct 21, 2015
@alan-knight @whesse
Hide internal methods like wrap_jso from the dart:html public interface
8d84f4c 
Issue #24602

R=terry@google.com

Review URL: https://codereview.chromium.org/1409743003 .
@mit-mit
Copy link
Member

mit-mit commented Oct 21, 2015

@alan-knight, is this ready to be merged or are there more commits needed?

@alan-knight
Copy link
Contributor

It has been merged. #24633

@kevmoo kevmoo reopened this Oct 22, 2015
@kevmoo
Copy link
Member Author

kevmoo commented Oct 22, 2015

screen shot 2015-10-21 at 5 49 26 pm

Still some more to do here

@mit-mit
Copy link
Member

mit-mit commented Nov 2, 2015

@kevmoo, can we move this to to 1.14? If not we need to get it fixed now.

@kevmoo
Copy link
Member Author

kevmoo commented Nov 2, 2015

@mit-mit I'm checking on this now. @alan-knight made some changes last week. Will update w/ what's left – if anything

@kevmoo
Copy link
Member Author

kevmoo commented Nov 2, 2015

screen shot 2015-11-02 at 10 19 09 am

@kevmoo
Copy link
Member Author

kevmoo commented Nov 2, 2015

https://codereview.chromium.org/1416043008/

@sethladd
Copy link
Contributor

sethladd commented Nov 2, 2015

Thanks @kevmoo !

@kevmoo kevmoo closed this as completed in 156bc53 Nov 2, 2015
@kevmoo kevmoo mentioned this issue Nov 2, 2015
Closed
kevmoo added a commit that referenced this issue Nov 3, 2015
@kevmoo @whesse
Hide implementation members in dart:html, dart:js and related libraries
8a57345 
Closes #24602

R=alanknight@google.com, jacobr@google.com, terry@google.com

Review URL: https://codereview.chromium.org/1416043008 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrylucas terrylucas

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
5 participants
@sethladd @kevmoo @terrylucas @alan-knight @mit-mit