Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pkg/analyzer to pkg/crypto >=0.9.2 <2.0.0 – fix deprecations #26138

Closed
kevmoo opened this issue Mar 30, 2016 · 6 comments
Closed

Update pkg/analyzer to pkg/crypto >=0.9.2 <2.0.0 – fix deprecations #26138

kevmoo opened this issue Mar 30, 2016 · 6 comments
Assignees
@kevmoo
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@kevmoo
Copy link
Member

kevmoo commented Mar 30, 2016

A few deprecations – blocks folks who depend on analyzer from getting strong-mode clean
@kevmoo kevmoo added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Mar 30, 2016
@kevmoo kevmoo mentioned this issue Mar 30, 2016
Closed
@nex3
Copy link
Member

nex3 commented Mar 30, 2016

Please actually use >=0.9.2 <2.0.0, as the changelog requests.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 30, 2016

Please actually use >=0.9.2 <2.0.0, as the changelog requests.

Yup – we should just stop using the deprecated APIs – will change title

@kevmoo kevmoo changed the title Update pkg/analyzer to pkg/crypto ^1.0.0 Update pkg/analyzer to pkg/crypto >=0.9.2 <2.0.0 – fix deprecations Mar 30, 2016
@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Mar 31, 2016
@kevmoo
Copy link
Member Author

kevmoo commented Apr 14, 2016

@bwilkerson I'd like to bump the priority on this – lots of folks are using analyzer package and they can't get the latest crypto.

Or they version solver is giving them the latest version of crypto and an older version of analyzer – pkg/test this is what happens.

@kevmoo kevmoo self-assigned this Apr 14, 2016
@kevmoo
Copy link
Member Author

kevmoo commented Apr 14, 2016

I'll take a look at this quick...

@kevmoo
Copy link
Member Author

kevmoo commented Apr 14, 2016

Started here https://codereview.chromium.org/1890973003/

kevmoo added a commit that referenced this issue Apr 15, 2016
@kevmoo
pkg/analyzer: support latest pkg/crypto version
5b5312a 
BUG= #26138
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org/1890973003 .
@kevmoo
Copy link
Member Author

kevmoo commented Apr 15, 2016

Closed in 5b5312a

@kevmoo kevmoo closed this as completed Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevmoo kevmoo

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nex3 @kevmoo @bwilkerson