GCC 14 build failure on BoringSSL

[selfisekai]

Build of 3.6.0-334.4.beta fails on GCC 14 (same boringssl_rev is on main, too)

Failure log (long)

ninja: job failed: g++ -MMD -MF obj/third_party/boringssl/src/ssl/ssl.ssl_file.o.d -DNDEBUG -DBORINGSSL_ALLOW_CXX_RUNTIME -DBORINGSSL_IMPLEMENTATION -DBORINGSSL_NO_STATIC_INITIALIZER -DOPENSSL_SMALL -DOPENSSL_STATIC_ARMCAP -D_XOPEN_SOURCE=700 -I../.. -Igen -I../../third_party/boringssl/src/include -m64 -march=x86-64 -msse2 -fPIE -fdebug-prefix-map=/home/lauren/aports/testing/dart/src/dart-sdk-3.6.0-334.4.beta/= -no-canonical-prefixes -fvisibility=hidden -Os -fstack-clash-protection -Wformat -Werror=format-security -fno-plt -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -fno-ident -fdata-sections -ffunction-sections -g3 -ggdb3 -fvisibility=hidden -Wendif-labels -Wno-missing-field-initializers -Wno-unused-parameter -Wno-ignored-qualifiers -fvisibility-inlines-hidden -fno-omit-frame-pointer -std=c++17 -std=c++17 -fno-rtti -std=c++14 -c ../../third_party/boringssl/src/ssl/ssl_file.cc -o obj/third_party/boringssl/src/ssl/ssl.ssl_file.o
In file included from ../../third_party/boringssl/src/ssl/internal.h:168,
                 from ../../third_party/boringssl/src/ssl/ssl_file.cc:124:
../../third_party/boringssl/src/ssl/../crypto/internal.h: In function 'uint32_t CRYPTO_addc_u32(uint32_t, uint32_t, uint32_t, uint32_t*)':
../../third_party/boringssl/src/ssl/../crypto/internal.h:1183:7: error: expected primary-expression before 'unsigned'
 1183 |       unsigned: __builtin_addc,                     \
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1190:10: note: in expansion of macro 'CRYPTO_GENERIC_ADDC'
 1190 |   return CRYPTO_GENERIC_ADDC(x, y, carry, out_carry);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1184:7: error: expected primary-expression before 'unsigned'
 1184 |       unsigned long: __builtin_addcl,               \
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1190:10: note: in expansion of macro 'CRYPTO_GENERIC_ADDC'
 1190 |   return CRYPTO_GENERIC_ADDC(x, y, carry, out_carry);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1185:7: error: expected primary-expression before 'unsigned'
 1185 |       unsigned long long: __builtin_addcll))((x), (y), (carry), (out_carry))
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1190:10: note: in expansion of macro 'CRYPTO_GENERIC_ADDC'
 1190 |   return CRYPTO_GENERIC_ADDC(x, y, carry, out_carry);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1182:4: error: '_Generic' was not declared in this scope
 1182 |   (_Generic((x),                                    \
      |    ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1190:10: note: in expansion of macro 'CRYPTO_GENERIC_ADDC'
 1190 |   return CRYPTO_GENERIC_ADDC(x, y, carry, out_carry);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h: In function 'uint64_t CRYPTO_addc_u64(uint64_t, uint64_t, uint64_t, uint64_t*)':
../../third_party/boringssl/src/ssl/../crypto/internal.h:1183:7: error: expected primary-expression before 'unsigned'
 1183 |       unsigned: __builtin_addc,                     \
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1196:10: note: in expansion of macro 'CRYPTO_GENERIC_ADDC'
 1196 |   return CRYPTO_GENERIC_ADDC(x, y, carry, out_carry);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1184:7: error: expected primary-expression before 'unsigned'
 1184 |       unsigned long: __builtin_addcl,               \
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1196:10: note: in expansion of macro 'CRYPTO_GENERIC_ADDC'
 1196 |   return CRYPTO_GENERIC_ADDC(x, y, carry, out_carry);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1185:7: error: expected primary-expression before 'unsigned'
 1185 |       unsigned long long: __builtin_addcll))((x), (y), (carry), (out_carry))
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1196:10: note: in expansion of macro 'CRYPTO_GENERIC_ADDC'
 1196 |   return CRYPTO_GENERIC_ADDC(x, y, carry, out_carry);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1182:4: error: '_Generic' was not declared in this scope
 1182 |   (_Generic((x),                                    \
      |    ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1196:10: note: in expansion of macro 'CRYPTO_GENERIC_ADDC'
 1196 |   return CRYPTO_GENERIC_ADDC(x, y, carry, out_carry);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h: In function 'uint32_t CRYPTO_subc_u32(uint32_t, uint32_t, uint32_t, uint32_t*)':
../../third_party/boringssl/src/ssl/../crypto/internal.h:1235:7: error: expected primary-expression before 'unsigned'
 1235 |       unsigned: __builtin_subc,                       \
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1242:10: note: in expansion of macro 'CRYPTO_GENERIC_SUBC'
 1242 |   return CRYPTO_GENERIC_SUBC(x, y, borrow, out_borrow);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1236:7: error: expected primary-expression before 'unsigned'
 1236 |       unsigned long: __builtin_subcl,                 \
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1242:10: note: in expansion of macro 'CRYPTO_GENERIC_SUBC'
 1242 |   return CRYPTO_GENERIC_SUBC(x, y, borrow, out_borrow);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1237:7: error: expected primary-expression before 'unsigned'
 1237 |       unsigned long long: __builtin_subcll))((x), (y), (borrow), (out_borrow))
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1242:10: note: in expansion of macro 'CRYPTO_GENERIC_SUBC'
 1242 |   return CRYPTO_GENERIC_SUBC(x, y, borrow, out_borrow);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1234:4: error: '_Generic' was not declared in this scope
 1234 |   (_Generic((x),                                      \
      |    ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1242:10: note: in expansion of macro 'CRYPTO_GENERIC_SUBC'
 1242 |   return CRYPTO_GENERIC_SUBC(x, y, borrow, out_borrow);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h: In function 'uint64_t CRYPTO_subc_u64(uint64_t, uint64_t, uint64_t, uint64_t*)':
../../third_party/boringssl/src/ssl/../crypto/internal.h:1235:7: error: expected primary-expression before 'unsigned'
 1235 |       unsigned: __builtin_subc,                       \
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1248:10: note: in expansion of macro 'CRYPTO_GENERIC_SUBC'
 1248 |   return CRYPTO_GENERIC_SUBC(x, y, borrow, out_borrow);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1236:7: error: expected primary-expression before 'unsigned'
 1236 |       unsigned long: __builtin_subcl,                 \
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1248:10: note: in expansion of macro 'CRYPTO_GENERIC_SUBC'
 1248 |   return CRYPTO_GENERIC_SUBC(x, y, borrow, out_borrow);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1237:7: error: expected primary-expression before 'unsigned'
 1237 |       unsigned long long: __builtin_subcll))((x), (y), (borrow), (out_borrow))
      |       ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1248:10: note: in expansion of macro 'CRYPTO_GENERIC_SUBC'
 1248 |   return CRYPTO_GENERIC_SUBC(x, y, borrow, out_borrow);
      |          ^~~~~~~~~~~~~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1234:4: error: '_Generic' was not declared in this scope
 1234 |   (_Generic((x),                                      \
      |    ^~~~~~~~
../../third_party/boringssl/src/ssl/../crypto/internal.h:1248:10: note: in expansion of macro 'CRYPTO_GENERIC_SUBC'
 1248 |   return CRYPTO_GENERIC_SUBC(x, y, borrow, out_borrow);
      |          ^~~~~~~~~~~~~~~~~~~
ninja: subcommands failed
BUILD FAILED
>>> ERROR: dart: build failed

Issue solved in upstream: https://boringssl-review.googlesource.com/q/I974a0b04bbe4900419736044d0d8050f2b856d56

[dart-github-bot]

Summary: Building Dart 3.6.0-334.4.beta fails with GCC 14 due to BoringSSL compilation errors. Upstream fix exists.