[dartdev] `dart test` with build hooks in Flutter project

[dcharkes]

flutter clean && dart test with build hooks in a Flutter project fails because the implicit dart pub get fails as it's not a flutter project.

dart test actually succeeds itself. Inside getExecutableForCommand, ensureUpToDate is run, which runs something similar to dart pub get but it succeeds for Flutter projects.

We should use ensurePubspecResolved from the programmatic pub API which runs ensureUpToDate internally.

@sigurdm How does pub actually succeed in running pub get for a Flutter project from the Dart SDK this way?

[sigurdm]

How does pub actually succeed in running pub get for a Flutter project from the Dart SDK this way?

$FLUTTER_ROOT/bin/dart sets the $FLUTTER_ROOT env-var that will allow pub to resolve a flutter project.

Also ensureUpToDate is a fast-path validation of the current resolution. That might work without the $FLUTTER_ROOT set, because it just validates that all timestamps of pubspec.yamls mentioned by package_config.yaml are earlier than the timestamp of pubspec.lock which again is earlier than package_config.yaml. (That is a simplified version - but a reasonable mental model).

If the timestamps work out, no new resolution is done, and pub might not realize it is not inside flutter.

What is the desired behavior here? Do we expect dart test to work inside a flutter project?

[dcharkes]

What is the desired behavior here? Do we expect dart test to work inside a flutter project?

Yes, it does: flutter clean && dart test works in flutter create --template=package_ffi foo after I add the fix in https://dart-review.googlesource.com/c/sdk/+/453920/6/pkg/dartdev/lib/src/native_assets.dart

(Especially a dart from a Flutter SDK should work. I don't believe people necessarily run a flutter test. Unless, I'm holding it wrong!)

[sigurdm]

I would expect dart from the flutter sdk should already be able to resolve a flutter project - and does so in my local tests. Please report if otherwise.

It will not set up your plugins and do intl work that flutter pub get does.