Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster isNotEmpty on collections #34751

Closed
wants to merge 1 commit into from

Conversation

teresy
Copy link
Contributor

@teresy teresy commented Oct 11, 2018

Uses isNotEmpty instead of length (as recommended in Effective Dart docs)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@teresy
Copy link
Contributor Author

teresy commented Oct 11, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@sigmundch sigmundch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dart2js changes lgtm

@athomas
Copy link
Member

athomas commented Nov 7, 2018

@dart-bot dart-bot closed this in c92f9dc Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants