Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster isNotEmpty on collections #34751

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@teresy
Copy link
Contributor

commented Oct 11, 2018

Uses isNotEmpty instead of length (as recommended in Effective Dart docs)

@googlebot

This comment has been minimized.

Copy link

commented Oct 11, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no label Oct 11, 2018

@teresy

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Oct 11, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 11, 2018

@kevmoo kevmoo requested review from sigmundch and bwilkerson Oct 11, 2018

@sigmundch
Copy link
Member

left a comment

dart2js changes lgtm

@athomas

This comment has been minimized.

@dart-bot dart-bot closed this in c92f9dc Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.