Skip to content

Conversation

bernaferrari
Copy link
Contributor

@bernaferrari bernaferrari commented Jan 17, 2024

Inspired by https://www.romainguy.dev/posts/2024/micro-optimizations-in-kotlin-1/

We use on vm and wasm.

We shouldn't use in JsInt because:

JsInt and JsDouble is basically the same thing because they are backed by the same representation (JS number type). In JS bitwise operations truncate the number to 32-bits so you can't really use them for this case.

Java and Kotlin 2.0 are doing this. Benchmark on JVM.

Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/346687

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

Copy link

https://dart-review.googlesource.com/c/sdk/+/346687 has been updated with the latest commits from this pull request.

Copy link

https://dart-review.googlesource.com/c/sdk/+/346687 has been updated with the latest commits from this pull request.

1 similar comment
Copy link

https://dart-review.googlesource.com/c/sdk/+/346687 has been updated with the latest commits from this pull request.

@bernaferrari bernaferrari deleted the >> branch January 18, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant