More fixes for package.xml #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the build system
Codecov Report
@@ Coverage Diff @@
## release-6.3 #1031 +/- ##
============================================
Coverage 56.22% 56.22%
============================================
Files 300 300
Lines 23548 23548
============================================
Hits 13239 13239
Misses 10309 10309 |
jslee02
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DART does not depend on catkin in order to configure and build, we can specify that it's build type is cmake instead of catkin. This prevents catkin from complaining about the project not being a catkin package.
This brings us back to conforming to REP-136, which I had naively erased, since I wasn't aware of the nuances between a "catkin package" and a "third-party package" (dartsim is considered the latter).
This also adds a boost dependency that was missing.