Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable URDF parser to read visual and collision names #1410

Merged
merged 4 commits into from
Aug 29, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 29, 2019


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 29, 2019
@jslee02 jslee02 marked this pull request as ready for review August 29, 2019 01:12
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #1410 into master will decrease coverage by <.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
- Coverage   57.32%   57.31%   -0.01%     
==========================================
  Files         367      367              
  Lines       27517    27521       +4     
==========================================
  Hits        15774    15774              
- Misses      11743    11747       +4
Impacted Files Coverage Δ
dart/utils/urdf/DartLoader.cpp 78.78% <75%> (-0.06%) ⬇️
dart/dynamics/Skeleton.cpp 66.05% <0%> (-0.17%) ⬇️

@jslee02 jslee02 requested a review from mxgrey August 29, 2019 07:34
@jslee02 jslee02 merged commit e125098 into master Aug 29, 2019
@jslee02 jslee02 deleted the urdf_visual_collision_name branch August 29, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants