This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Implement TrackerApi::Client#notifications #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Contributor
There was a problem hiding this comment.
You can change this to be a project and story object since the API returns nested objects.
attribute :project, , TrackerApi::Resources::Project
attribute :story, , TrackerApi::Resources::Stroy
attribute :performer, TrackerApi::Resources::Person
Then you can remove the code where you manually pull out notification['story']['id'] and notification['project']['id'].
Contributor
Author
There was a problem hiding this comment.
Fix it. Please, check it.
Contributor
|
Thanks. I'll get this merged in. |
Contributor
Author
|
Thanks!! |
forest
added a commit
that referenced
this pull request
Jan 20, 2015
Implement TrackerApi::Client#notifications
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there.
I implemented 'notification' resource and 'notifications' endpoint.
Please, give me feedback if this pull request has any problems