Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Conversation

@forest
Copy link
Contributor

@forest forest commented Jan 5, 2017

No description provided.

@coveralls
Copy link

coveralls commented Jan 5, 2017

Coverage Status

Coverage increased (+0.02%) to 96.472% when pulling 93393db on drselump14-master into 7722730 on master.

@forest
Copy link
Contributor Author

forest commented Jan 5, 2017

@drselump14 I pulled your branch and added tests to make sure you can update story owners via the owner_ids setter.

Because of dirty tracking, you need to use the setter owner_ids=. You can't manipulate the array via typical array methods like << or push. That might have been your issue before.

It should work now with the latest code. You can see I just commented out your code and added tests.

@coveralls
Copy link

coveralls commented Jan 5, 2017

Coverage Status

Coverage increased (+0.02%) to 96.472% when pulling d8100fb on drselump14-master into 7722730 on master.

@drselump14
Copy link
Contributor

Thanks @forest ..
Is there any hope that << and push method can be implemented?
That would be more convenient when adding new owner to existing owners list

@forest
Copy link
Contributor Author

forest commented Jan 5, 2017

Agreed. I spend a few hours on that when I first added dirty tracking. I was getting really hacky because it meant monkey more patching Array methods. I even tried creating my own list object to encapsulate that functionality, but it didn't work. I forget why exactly. In the end, I just punted on it and put a note in the readme. Maybe some day I'll try again, or someone else can take a crack at it.

@forest forest merged commit a4977f5 into master Jan 5, 2017
@forest forest deleted the drselump14-master branch January 5, 2017 01:12
@drselump14
Copy link
Contributor

Why we don't just implement the << and push using pivotal tracker POST owner apis like I proposed before? Maybe we don't need to monkey patch the Array method, just implement a new class that inherits the Array class.

What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants