Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Conversation

@forest
Copy link
Contributor

@forest forest commented Jan 6, 2017

This might be an acceptable compromise to not supporting << for owner_ids. Also consistent with the add_label interface which exists for the same reasons.

@forest
Copy link
Contributor Author

forest commented Jan 6, 2017

@drselump14 how does this look? Not << but much clearer interface.

@coveralls
Copy link

coveralls commented Jan 6, 2017

Coverage Status

Coverage increased (+0.06%) to 96.534% when pulling 14fee7a on add-owners into fbbb085 on master.

@drselump14
Copy link
Contributor

@forest it's fine I guess ... consistent with what stated on readme

@forest
Copy link
Contributor Author

forest commented Jan 6, 2017

@drselump14 feel free to take a stab at implementing <<. I'm not against it, but it wasn't worth the effort for me. I haven't dug in too deep yet, but some of the http://dry-rb.org/gems gems could be used to replace Virtus and might make this easier. It would be a huge rewrite. From what I have read dry-rb gems are the next generation of Virtus.

@forest forest merged commit 0e4aa5a into master Jan 6, 2017
@forest forest deleted the add-owners branch January 9, 2017 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants