-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orphan blocks since upgrading #1822
Comments
Our pool is experiencing a similar problem: https://poolmining.org/pool/dash For the last 36 hours all mined blocks ended up as orphans. |
Crackfoo, any update on the orphan issue? 7 orphans in a row at poolmining. |
Still waiting for some dash dev to give some insight. Perhaps they
restricted what pools can mine dash now.
…On Thu, Dec 28, 2017 at 7:32 AM BlueStateBandit ***@***.***> wrote:
Crackfoo, any update on the orphan issue? 7 orphans in a row at poolmining.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1822 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGAv4oFrSYxKd4vr-q2Krfa2iA9LTKNjks5tE4pHgaJpZM4RN8Mp>
.
|
The same issue is discussed in p2pool repo dashpay/p2pool-dash#43, see my replies there. tl;dr: as far as I can see blocks are relayed properly and after they are relayed dashd has nothing to do with it, it's up to pools to pick the chain tip on top of which they mine.
That's not possible (to hide). The code source is right here, you can compile it for yourself. And again, orphan != invalid, these blocks were accepted before they were overridden by the "longer" chain. |
Almost sounds like a problem with 12.2.2 that gets emphasized the more nodes upgrade to that version. |
This is a 51% Attack |
@ilsawa Who's do you think is behind the attack? |
I think there is no 51% thing.
Check extraction status |
On the block 794500 - 51% |
guess that answers why. Are they manipulating the chain on purpose?
I've dropped it from my pool. Just a waste of hash.
…On Thu, Dec 28, 2017 at 2:58 PM, ilsawa ***@***.***> wrote:
On the block 794500 - 51%
https://chainz.cryptoid.info/dash/extraction.dws?38.htm
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1822 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGAv4uQZANU4TxPdRyzTFpGzCVwE-SA2ks5tE-TVgaJpZM4RN8Mp>
.
|
It seems that the network is divided into 2 segments. In one, the blocks do not linger, but in the other - the brakes. All nodes of the p2pool are in the slow segment. |
called reorganization
check your dashd logs |
log from my node
This is block (795065) found by my node - ORPHAN |
If you check debug.log you'll see that it's not the generation time but a time when reorg happened (more or less, time is not consistent across different nodes).
I don't see any proofs for this on my nodes, blocks are relayed normally. Check your logs to see if there is a delay.
Again, this has nothing to do with p2pool. Other pools suffer from this issue too. The only way to solve this imo is to ask miners to move away from few top pools and spread their hashes across smaller pools. |
Here is the proof that the network is working abnormally https://chainz.cryptoid.info/dash/orphans.dws |
@ilsawa no, it's not imo. It's just the proof that reorgs happen much more often in last few days. But reorg in general is a legit way to resolve forking, there is nothing wrong with reorgs themselves. What is not ok is that some pools with huge power basically ignore the chain tip and mine whatever they want instead of mining on top of current tip and I think this what causes much higher rate of reorgs/orphans, not the behavior of the network. |
But how would they do that? Mess with the result of |
@UdjinM6 P2pool and now has enough power to find the blocks every 3 hours
|
I'm running 7 P2Pool Nodes with a combined HashRate of just under 7Th/s. We are seeing 90% of all found blocks "Orphaned". This is not normal and there has to be a fix for this. Any suggestions would be appreciated! |
@ourlink |
@ilsawa I'm increasing the connections on my nodes. I originally had a limit set in dash.conf. |
@ourlink I'm just trying to understand and catch dependencies. |
@UdjinM6 Could you provide some insight as to whether the team is actively working on a solution? |
I'm running my dash core node with modified version of 0.12.2.2 to accept peer 70206 which also being used by p2pool-dash node. After started, p2pool block 795344 is not orphaned. |
@thelazier can you share your modified DASHD? |
My pools have not seen a P2POOL-DASH found block since 794925 what has been found since then are all orphaned. I believe this is a P2POOL issue at this time because all the blocks found from 794925 with the exception of 4 were not found by P2Pool. |
@UdjinM6 One way to improve the distribution of hashpower would be to clean up https://www.dash.org/mining. Antpool is listed at the top and the list includes sites that aren't pools at all or pools which have been dead for a long time. |
And they need to change the link to p2pool. @UdjinM6 Replace the link to the source code https://github.com/dashpay/p2pool-dash with a link to p2pool scanner http://www.p2poolmining.us/p2poolnodes/ |
I agree to those suggestions! BTW - P2Pool-DASH just found two blocks back to back within a minute of each other. Hope this is the end to the orphans! |
If this is working now, does anyone know what happened? Or just guesses still? |
Turned out that some pools were actually rejecting some blocks. They restarted their nodes, so should be ok for now. We are still investigating what caused the issue exactly. |
@UdjinM6 Any conclusions yet? |
This was fixed with https://github.com/dashpay/dash/releases/tag/v0.12.2.3 |
unsure why now all our blocks end up orphaned since we upgraded to latest client.
2017-12-28 00:04:29 CreateNewBlock(): total size 14373 txs: 19 fees: 1231323 sigops 144
2017-12-28 00:04:30 UpdateTip: new best=000000000000000933aed4e4e968498d09c25a87a9002e712470b9ff383e01e8 height=794431 log2_work=72.927919 tx=4486957 date=2017-12-28 00:04:29 progress=1.000000 cache=5.2MiB(38802txo)
2017-12-28 00:04:30 AddToWallet 50bbb24c1142a83eb49d0298723da22b5ca622850688e5dfc067d62b2f92b1f8 new
2017-12-28 00:04:30 ProcessNewBlock : ACCEPTED
debug: http://paste.ubuntu.com/26268585/
http://zpool.ca/site/block?id=893
unsure if this is any important:
2017-12-28 00:07:24 ERROR: Requesting unset send version for node: 835. Using 209
The text was updated successfully, but these errors were encountered: