-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(dip27): dash core credit pool #152
Conversation
Co-authored-by: Konstantin Akimov <knstqq@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 442ee61
overall it seems fine, but check a correction about withdrawal limit
Co-authored-by: Konstantin Akimov <knstqq@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 572b53c
Needs to mention that Also, we need to know during the signing phase with the nulled-out Tx, does the SigHash signing byte go before or after the signing bytes? Like this? if (extraPayload) {
let nExtraPayload = Tx.utils.toVarInt(extraPayload.length / 2);
tx.push(nExtraPayload);
tx.push(extraPayload);
}
if (sigHashType) { // for null-inputs tx for signing
let sigHashTypeHex = TxUtils._toUint32LE(sigHashType);
let sigHashTypeHex = TxUtils.toUint32LE(sigHashType);
tx.push(sigHashTypeHex);
} Or like this? if (sigHashType) { // for null-inputs tx for signing
let sigHashTypeHex = TxUtils.toUint32LE(sigHashType);
tx.push(sigHashTypeHex);
}
if (extraPayload) {
let nExtraPayload = Tx.utils.toVarInt(extraPayload.length / 2);
tx.push(nExtraPayload);
tx.push(extraPayload);
}
let txHex = tx.join(_sep); |
Re: We're adding Platform support to the modern Dash SDK: |
I don't fully understand the question here and a couple people I asked weren't sure either. We thought maybe this is not related specifically to the asset lock and applies generically to special txs?. Trying to figure out how to get an answer for the question and also where that answer fits best.
|
Includes change from Pasta plus some refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 28f494b
This DIP provides a mechanism for locking and unlocking Dash in a new store of value on the Core chain. The store of value, called the credit pool, mirrors the credit balance on Dash Platform. New special transactions enable locking Dash in the credit pool for use on Platform and unlocking it to withdraw back to Dash on the Core chain.