Skip to content

Clarify eig and eigvals todos #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2021
Merged

Clarify eig and eigvals todos #204

merged 1 commit into from
Jun 28, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Jun 21, 2021

This PR

  • updates the TODOs to indicate that the function eig and eigvals are dependent on complex number support being added to the specification.

@rgommers rgommers added the Maintenance Bug fix, typo fix, or general maintenance. label Jun 28, 2021
rgommers
rgommers approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kgryte and @oleksandr-pavlyk

@rgommers rgommers merged commit dffc7ab into main Jun 28, 2021
@rgommers rgommers deleted the clarify-eig-todos branch June 28, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgryte @rgommers @oleksandr-pavlyk