Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex number support to linalg.trace #541

Merged
merged 1 commit into from Dec 13, 2022
Merged

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Dec 1, 2022

This PR

  • adds support for complex numbers to linalg.trace and follows the guidance set forth in Add complex number support to sum #538.
  • specifies that special cases be derived as if the operation was implemented as a reduction over add.
  • requires that, if x is a complex floating-point data type and dtype is None, the function must return an array having the default complex floating-point data type.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 1, 2022
@kgryte kgryte added this to the v2022 milestone Dec 1, 2022
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is pretty straightforward, and looks consistent with sum. In it goes, thanks @kgryte

@rgommers rgommers merged commit 35cbf3d into main Dec 13, 2022
@rgommers rgommers deleted the cmplx-linalg-trace branch December 13, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants