Skip to content

fix(renderer): do not fail when using or #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Mar 30, 2020

Copy pasted code, forgot to change and to or :(

This has to be backported to v1

@rvsia rvsia added bug Something isn't working renderer React form renderer PR labels Mar 30, 2020
@rvsia rvsia requested a review from Hyperkid123 March 30, 2020 10:51
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #405 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files         135      135           
  Lines        2145     2145           
  Branches      701      701           
=======================================
  Hits         1907     1907           
  Misses        238      238           
Impacted Files Coverage Δ
...orm-renderer/src/files/default-schema-validator.js 98.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe95b7...ffe1c10. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit be95c78 into data-driven-forms:master Mar 30, 2020
@Hyperkid123
Copy link
Member

🎉 This PR is included in version 2.0.2 🎉

The release is available on

Demo can be found here!

@rvsia rvsia deleted the fixOrCondition branch April 28, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released renderer React form renderer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants